Re: [PATCH 2/2] Implement pid_to_exec_file for Windows in gdbserver

[Tom Tromey <tromey@adacore.com>]

Simon> It seems a bit strange to pass a pid to this method.  Doesn't a
Simon> windows_process_info object know its own pid?

It does, but only in gdbserver.  And, even there, the 'id' field isn't
really needed and can be removed -- it just replicates information
already stored elsewhere.

Simon> So maybe we can have a gdb_assert in
Simon> windows_nat_target::pid_to_exec_file to verify that (and the same
Simon> GDBserver-side)?

... so I think instead of doing this, I'd rather just drop the 'id'
field.

Simon> The day the windows-nat target becomes multi-process, then I guess we'll
Simon> use the passed-in pid to look up a specific windows_process_info by pid
Simon> in whatever data structure will contain all the windows_process_infos.
Simon> And then we can call windows_process_info::pid_to_exec_file without
Simon> passing any pid.

I think we'll still need to pass it, given that the Cygwin code needs
it.

Tom