From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x135.google.com (mail-il1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) by sourceware.org (Postfix) with ESMTPS id 0E1F23858406 for ; Mon, 25 Apr 2022 18:27:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0E1F23858406 Received: by mail-il1-x135.google.com with SMTP id y11so9922124ilp.4 for ; Mon, 25 Apr 2022 11:27:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=FyHOuDmMQaVwIL4j+3upmib5+g2Z3QC05ULTPvysscE=; b=R58nKlaDftaEfgzmBNaPmvoT7Ju//YYbDL4ujavx7Q1PDOw98DzLr1IKUcNim8ek0J 3RyzbOzv3+YvucgWX7BOOx1ioZ1bDXkZ+XF3WjuRQhe94Zp42VC2BrLAvd2hy8mW1qzc 1I8UkL9xv5vO8kD8QHD7tSH1dFsTn0XcQXyqP7J06ovb0c8dBqf5gmTDhK8JWopkfjUd iYF5/Xrd6yp9dXYX1FzyBNyIAWTwdUaA47BL1qMOccTVRzsnUqNmq8/DM8+w4XEfydtH Vt2+w7jzRbq3pm2DIBpICCm6y4mw7VWIBQXsFl5VtAelvNv57CrMBR5tkJa3piNYT58E d1nA== X-Gm-Message-State: AOAM532m7JP8F/0w3H90D+uM/P9LVek2koyoTxMw82XHMVdBzA4CVC7E BI9moFdCmudKr4sintr8kysY8d+mEhpLbA== X-Google-Smtp-Source: ABdhPJyumN84igNShYktt+Yvrt27c+UX4Iz9ZvtCeSeAgOI/z8l/U6mQJYLfk3QWMMTlDzM5SHnxDQ== X-Received: by 2002:a92:7513:0:b0:2b9:5b61:e376 with SMTP id q19-20020a927513000000b002b95b61e376mr7806925ilc.193.1650911278222; Mon, 25 Apr 2022 11:27:58 -0700 (PDT) Received: from murgatroyd (71-211-158-194.hlrn.qwest.net. [71.211.158.194]) by smtp.gmail.com with ESMTPSA id u12-20020a056e02170c00b002cc27d7fe26sm7150702ill.22.2022.04.25.11.27.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Apr 2022 11:27:57 -0700 (PDT) From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix method naming bug in new DWARF indexer References: <20220421163831.2582161-1-tromey@adacore.com> <02551264-3beb-0348-07da-e61dbf9681c8@palves.net> X-Attribution: Tom Date: Mon, 25 Apr 2022 12:27:55 -0600 In-Reply-To: <02551264-3beb-0348-07da-e61dbf9681c8@palves.net> (Pedro Alves's message of "Fri, 22 Apr 2022 13:19:23 +0100") Message-ID: <87mtg9ow5w.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Apr 2022 18:28:00 -0000 Pedro> The "much slower" aspect remains, this patch does not change it. Pedro> The size of the generated index roughly the same as from before Pedro> this patch, and it is still much larger than from before the new Pedro> DWARF indexer landed. I think that will require a separate fix. Pedro> I sent you more info Pedro> about it off list. I have a patch to fix the size problem. It works by only emitting a given type or variable once. This is what the gdb used to do via the psymbol bcache. It could sometimes mean that "info types" would miss a duplicate -- but the old code did this as well. I'll send this soon. However, this patch doesn't fix the performance problem. I am not sure it is really fixable, given that the code has to compute the full name of every entry in the index. If we check in the background-writing code, this won't be noticeable for the index cache case. However, it will still be noticeable for "gdb-add-index". Tom