From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by sourceware.org (Postfix) with ESMTPS id A0525394CC12 for ; Thu, 12 Aug 2021 18:03:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A0525394CC12 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-oi1-x230.google.com with SMTP id t128so11672977oig.1 for ; Thu, 12 Aug 2021 11:03:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=2xyXMuMf/vK3ljfV3GbLVudcQawQ7DO0cu4pMOBHtBY=; b=PALWxOwMMz+Q7kju4bL+im6VL07Bo+UWmDdulLGiTLXtYpe0eZwLk3saKDND2PNKG9 qEKKcejhADWThOpOQMVi/Bv+sHJcxptJW07t5MnSPwQESqNmBpiZ5ceejCAyZx/X9dF4 2YOVMW6PWsbWhw5BjbqXLxHsSSb1xgYXiuSSQQFIERcQCU9p7Rrydn5DBb7/mC+vvyE8 hQ4VCie/BmJHXjx5LOQMW/cBXOFA+yxjelJZF40VAZqG0KLV4lZAMd37PfhZFP/oEzJ2 FxKwF4YOrpWqDPLoahKjO5eloyPCMoeqMXc2wZPF4Lm2barVnII+/XZpbjYt1B98ceWz T/Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=2xyXMuMf/vK3ljfV3GbLVudcQawQ7DO0cu4pMOBHtBY=; b=Im8w7C5X24JLuCMBYayngjSrZ3O+0rbG7HwchoRDJB+GQl3kP5zh9c/R3OLPNFoYba i3esrvrgAd7WVM5xK69amREQC+pyowX2iz//vQNbkupu7Ri07NCABTykca0FlZQ2ChDc KjIYnEZzbXKfPgbmJe8cWCWpvbBmbRdvFsuDRZlw8WjB7q6Cvcr5YIAI9w9aYgl5IzwF 5jEdRNt0qc2w+OhXV7UWMdE0PGEincPnpve2zLYf+IlUJT/3ymG9FWR+44YIapXlbz+m C+kvRSAK1sPz2+30vZv6wA6FaJZEz/25xIuU3EmPZljhrqZy+KEXHE6CjJ0I6o8JdKnj cM+Q== X-Gm-Message-State: AOAM530L+P9lxhnKgQFrCR40luHiYQPWxab+uio4rSvJnZ8kD4MiDBOJ 2iLMK2WqM9zU9TS9Y686wv/1sA== X-Google-Smtp-Source: ABdhPJxyS4szkzdVDzLNHGOsev0UJ1n7AXpBIHK34Q3poA3Xe/0NHFAdpi5/6ejFVquuflfouvYx+Q== X-Received: by 2002:a05:6808:158e:: with SMTP id t14mr2763592oiw.113.1628791405091; Thu, 12 Aug 2021 11:03:25 -0700 (PDT) Received: from murgatroyd (97-122-71-196.hlrn.qwest.net. [97.122.71.196]) by smtp.gmail.com with ESMTPSA id b1sm846437ots.29.2021.08.12.11.03.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Aug 2021 11:03:24 -0700 (PDT) From: Tom Tromey To: Tom Tromey Cc: Zoran Zaric via Gdb-patches , Zoran Zaric Subject: Re: [PATCH v3 15/17] Make DWARF evaluator return a single struct value References: <20210528154648.60881-1-zoran.zaric@amd.com> <20210528154648.60881-16-zoran.zaric@amd.com> <87v94bdihd.fsf@tromey.com> X-Attribution: Tom Date: Thu, 12 Aug 2021 12:03:23 -0600 In-Reply-To: <87v94bdihd.fsf@tromey.com> (Tom Tromey's message of "Wed, 11 Aug 2021 11:00:30 -0600") Message-ID: <87mtpmczh0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_ABUSEAT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Aug 2021 18:03:36 -0000 Zoran> At this point, all conditions are met for the DWARF evaluator to return Zoran> an evaluation result in a form of a single struct value object. Tom> Hi. On an internal test case, using an arm-elf target, this patch Tom> causes a regression. (It doesn't happen for any of the other cross Tom> targets that I test when importing upstream gdb.) I've tested this patch, plus another one related to this series that I didn't bring up yesterday. They are here: https://sourceware.org/pipermail/gdb-patches/2021-August/181432.html I'd appreciate any input you might have. thanks, Tom