From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway32.websitewelcome.com (gateway32.websitewelcome.com [192.185.145.178]) by sourceware.org (Postfix) with ESMTPS id 9FE42394AC0A for ; Wed, 4 Aug 2021 15:53:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9FE42394AC0A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 2E37887000 for ; Wed, 4 Aug 2021 10:52:56 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id BJCSm3vbLLjoRBJCSmCEm8; Wed, 04 Aug 2021 10:52:56 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gkP1BhlrYre3Cd2RpNpwXRxQV1AiGYIEdupAMiR6azQ=; b=NXjmxxeGv+qvfm+WcCyjQQgS08 NE0CZ69gSryE22JVihIKKcoHho1YQUExw4uiE6afrJ8XvrO5f4kreSd3q9ntMgdPnjHrtrG1EzqU5 A7Zo3BscMMyvhc9MXWpQ0zMAj; Received: from 97-122-71-26.hlrn.qwest.net ([97.122.71.26]:53472 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mBJCR-000GOU-Qz; Wed, 04 Aug 2021 09:52:55 -0600 From: Tom Tromey To: Simon Marchi via Gdb-patches Subject: Re: [PATCH 1/3] gdb: fix typo in complaint in dwarf2/macro.c References: <5a9d2735-042b-47fd-b794-a9ff8c18b384@polymtl.ca> <20210803153114.2516992-1-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Wed, 04 Aug 2021 09:52:55 -0600 In-Reply-To: <20210803153114.2516992-1-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Tue, 3 Aug 2021 11:31:12 -0400") Message-ID: <87mtpx5hrc.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.71.26 X-Source-L: No X-Exim-ID: 1mBJCR-000GOU-Qz X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-71-26.hlrn.qwest.net (murgatroyd) [97.122.71.26]:53472 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Aug 2021 15:53:10 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> I saw this complaint when my code had some bug, and spotted the typo. Simon> Fix it, and while at it mention DW_MACRO as well (it would be confusing Simon> to only see DW_MACINFO with a file that uses a DWARF 5 .debug_macro Simon> section). I contemplated the idea of passing the knowledge of whether Simon> we are dealing with a .debug_macro section or .debug_macinfo section, to Simon> print only the right one. But in the end, I don't think that trouble is Simon> necessary for a complaint nobody is going to see. Makes sense to me. Tom