From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway21.websitewelcome.com (gateway21.websitewelcome.com [192.185.45.163]) by sourceware.org (Postfix) with ESMTPS id AD7AB3953D03 for ; Mon, 14 Jun 2021 15:11:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AD7AB3953D03 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 95AAB4016CD71 for ; Mon, 14 Jun 2021 10:07:55 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id soBvlhQcnELyOsoBvlUxUL; Mon, 14 Jun 2021 10:07:55 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=lvHE3jF+7ZbLVhHrJ14TzdL7tMm30Lt36JoEy8WwTK4=; b=RGp9+FMEg2UGUIxIJBEq3FztEl i2kVcrXzdOMDmMuAm+PlZpMtCnI9nlnZHTTO/wsfNxjkdif9a713bKS2YTF9AO+bLBXllKPlQdxnh cS132i2WIq4JoivE8ikjMdpgt; Received: from 97-122-81-113.hlrn.qwest.net ([97.122.81.113]:48608 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lsoBv-0047ZC-9Z; Mon, 14 Jun 2021 09:07:55 -0600 From: Tom Tromey To: Rainer Orth Cc: Bernd Edlinger , Tom Tromey , "gdb-patches@sourceware.org" Subject: Re: [PATCH] Fix gdb crash due to SIGPIPE when the compile command fails References: <87tumgp1ob.fsf@tromey.com> <87zgw5oijf.fsf@tromey.com> X-Attribution: Tom Date: Mon, 14 Jun 2021 09:07:54 -0600 In-Reply-To: (Rainer Orth's message of "Mon, 14 Jun 2021 14:59:47 +0200") Message-ID: <87mtrsfprp.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.81.113 X-Source-L: No X-Exim-ID: 1lsoBv-0047ZC-9Z X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-81-113.hlrn.qwest.net (murgatroyd) [97.122.81.113]:48608 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3026.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jun 2021 15:11:46 -0000 Rainer> that's what I've been using myself to fix the build locally. However, Rainer> as I said I'm completely uncertain if that's the right fix, especially Rainer> given that gdb/compile files don't include any system headers directly. That must just be happenstance. Normally, a universally-available system header can be included anywhere. Sometimes there is a wrapper header, and so in these cases one ought to use the wrapper instead. There's no particular ordering of headers, except that defs.h (gdbsupport and gdbserver have similar, but differently-named headers) must come first. (We looked into a script to reorder headers but I never finished ironing out the bugs.) Tom