[pushed] Move enum noside earlier in expression.h

[pushed] Move enum noside earlier in expression.h

[Tom Tromey]

For the expression rewrite series, I needed to move enum noside
earlier in expression.h.  Because this is a pure move, and because it
seems harmless and uncontroversial to move an enum definition earlier
in a file, I'm pushing it in early, to reduce the size of that series.

Tested by rebuilding.

gdb/ChangeLog
2020-12-21  Tom Tromey  <tom@tromey.com>

	* expression.h (enum noside): Move earlier.
---
 gdb/ChangeLog    |  4 ++++
 gdb/expression.h | 44 ++++++++++++++++++++++----------------------
 2 files changed, 26 insertions(+), 22 deletions(-)

diff --git a/gdb/expression.h b/gdb/expression.h
index c07111c316f..f30c79309ae 100644
--- a/gdb/expression.h
+++ b/gdb/expression.h
@@ -67,6 +67,28 @@ enum exp_opcode : uint8_t
     OP_UNUSED_LAST
   };
 
+/* Values of NOSIDE argument to eval_subexp.  */
+
+enum noside
+  {
+    EVAL_NORMAL,
+    EVAL_SKIP,			/* Only effect is to increment pos.
+				   Return type information where
+				   possible.  */
+    EVAL_AVOID_SIDE_EFFECTS	/* Don't modify any variables or
+				   call any functions.  The value
+				   returned will have the correct
+				   type, and will have an
+				   approximately correct lvalue
+				   type (inaccuracy: anything that is
+				   listed as being in a register in
+				   the function in which it was
+				   declared will be lval_register).
+				   Ideally this would not even read
+				   target memory, but currently it
+				   does in many situations.  */
+  };
+
 union exp_element
   {
     enum exp_opcode opcode;
@@ -135,28 +157,6 @@ extern expression_up parse_exp_1 (const char **, CORE_ADDR pc,
 
 /* From eval.c */
 
-/* Values of NOSIDE argument to eval_subexp.  */
-
-enum noside
-  {
-    EVAL_NORMAL,
-    EVAL_SKIP,			/* Only effect is to increment pos.
-				   Return type information where
-				   possible.  */
-    EVAL_AVOID_SIDE_EFFECTS	/* Don't modify any variables or
-				   call any functions.  The value
-				   returned will have the correct
-				   type, and will have an
-				   approximately correct lvalue
-				   type (inaccuracy: anything that is
-				   listed as being in a register in
-				   the function in which it was
-				   declared will be lval_register).
-				   Ideally this would not even read
-				   target memory, but currently it
-				   does in many situations.  */
-  };
-
 extern struct value *evaluate_subexp_standard
   (struct type *, struct expression *, int *, enum noside);
 
-- 
2.17.2

Re: [pushed] Move enum noside earlier in expression.h

[Tom Tromey]

>>>>> "Tom" == Tom Tromey <tom@tromey.com> writes:

Tom> For the expression rewrite series, I needed to move enum noside
Tom> earlier in expression.h.  Because this is a pure move, and because it
Tom> seems harmless and uncontroversial to move an enum definition earlier
Tom> in a file, I'm pushing it in early, to reduce the size of that series.

Tom> Tested by rebuilding.

Tom> gdb/ChangeLog
Tom> 2020-12-21  Tom Tromey  <tom@tromey.com>

Tom> 	* expression.h (enum noside): Move earlier.

I'm checking this in.

Tom

Re: [pushed] Move enum noside earlier in expression.h

[Tom Tromey]

Tom> * expression.h (enum noside): Move earlier.

Tom> I'm checking this in.

Haha, I pushed this already and it says it right there in the subject.

Tom