From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway20.websitewelcome.com (gateway20.websitewelcome.com [192.185.53.25]) by sourceware.org (Postfix) with ESMTPS id 93EB8386F83F for ; Wed, 9 Dec 2020 21:12:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 93EB8386F83F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 504EE400CEA20 for ; Wed, 9 Dec 2020 15:08:22 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id n6lLk9WRbiQiZn6lLkfT2l; Wed, 09 Dec 2020 15:12:39 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=THV0iweDgeuccgmSOIFMBWxZusSmldJUSV67CTdGNBI=; b=TBV1km6uWJA9nTEQs0NX2e6rHm TJDFZ8Yi0Nt4QJvImXXJ1V0AEBZINcZdkOFIihZbjCZvUgvlUxf9zgjGZhhmk2u/gpm36gOeHEVYh 42/JZR47m9lDEBVF2yjsXQTLm; Received: from 97-122-89-243.hlrn.qwest.net ([97.122.89.243]:59556 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1kn6lK-002y61-QV; Wed, 09 Dec 2020 14:12:38 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi , nilsgladitz@gmail.com Subject: Re: [PATCH 2/4] gdb/dwarf: add assertion in maybe_queue_comp_unit References: <20201117191231.2712629-1-simon.marchi@polymtl.ca> <20201117191231.2712629-3-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Wed, 09 Dec 2020 14:12:38 -0700 In-Reply-To: <20201117191231.2712629-3-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Tue, 17 Nov 2020 14:12:29 -0500") Message-ID: <87mtymr8e1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.89.243 X-Source-L: No X-Exim-ID: 1kn6lK-002y61-QV X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-89-243.hlrn.qwest.net (murgatroyd) [97.122.89.243]:59556 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Dec 2020 21:12:42 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> gdb/ChangeLog: Simon> * dwarf2/read.c (maybe_queue_comp_unit): Add assertion. Thank you for tracking this down. Simon> + /* Verify the invariant that if a CU is queue for expansion, its DIEs are Probably should s/queue/queued/ here. Tom