From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <pedro@palves.net>
Cc: Andrew Burgess <andrew.burgess@embecosm.com>,
Tom Tromey <tom@tromey.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: improve command completion for 'print', 'x', and 'display'
Date: Fri, 20 Nov 2020 08:55:28 -0700 [thread overview]
Message-ID: <87mtzcggzz.fsf@tromey.com> (raw)
In-Reply-To: <e728af3d-62e0-cce8-462a-41c2c8f1b909@palves.net> (Pedro Alves's message of "Fri, 20 Nov 2020 13:47:37 +0000")
>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:
Pedro> I assumed it was on purpose that those weren't used, since you've
Pedro> included safe-ctype.h and are (rightfully IMO) using ISSPACE and not
Pedro> isspace. skip_spaces/skip_to_space use isspace not ISSPACE.
Pedro> Probably doesn't make a difference in practice. Not sure there's
Pedro> any locale where isspace/ISSPACE return a different result.
Pedro> ISSPACE is cheaper, so maybe we should make skip_spaces/skip_to_space
Pedro> use it.
skip_* are intended for use by gdb commands -- they originally lived in
gdb/cli/ -- so if they do the wrong thing in some situation, they should
definitely be changed.
Tom
next prev parent reply other threads:[~2020-11-20 15:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 15:42 Andrew Burgess
2020-11-16 23:53 ` Pedro Alves
2020-11-18 16:11 ` Tom Tromey
2020-11-19 10:14 ` Andrew Burgess
2020-11-20 13:47 ` Pedro Alves
2020-11-20 15:55 ` Tom Tromey [this message]
2020-11-21 10:42 ` Andrew Burgess
2020-12-03 17:03 ` Tom Tromey
2020-12-11 22:07 ` Andrew Burgess
2021-01-06 7:39 ` gdbserver build broken with -fsanitize=address Tom de Vries
2021-01-06 16:29 ` [PATCH][gdb/build] Fix gdbserver build " Tom de Vries
2021-01-07 9:24 ` Andrew Burgess
2020-11-26 19:12 ` [PATCH] gdb: improve command completion for 'print', 'x', and 'display' Simon Marchi
2020-11-27 11:13 ` Andrew Burgess
2020-11-27 14:04 ` Simon Marchi
2021-01-08 0:59 ` Pedro Alves
2021-01-08 10:34 ` Andrew Burgess
2021-01-08 15:08 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtzcggzz.fsf@tromey.com \
--to=tom@tromey.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).