From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com [192.185.47.228]) by sourceware.org (Postfix) with ESMTPS id 8AFE13857007 for ; Wed, 1 Jul 2020 19:18:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8AFE13857007 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway22.websitewelcome.com (Postfix) with ESMTP id A789E13235 for ; Wed, 1 Jul 2020 14:17:50 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id qiEwj1DUMzOauqiEwjBur3; Wed, 01 Jul 2020 14:17:50 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=IenSg53B9Xm65XtnhbgVJmGrvSGU8BgkqjedWbQbVDw=; b=LSQHG5mLQYRPx/YqNKym0HgJPI Xnq3b07xgInhpKJUaXMzrfbEvTiDc1NnqzPI4FOqF32bYAq+wVVLIafsslxnjSKbGcqhPdTUkCr0B AS2wT1XaX9kBavHYjRHECugtj; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:51802 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jqiEw-0018wZ-BV; Wed, 01 Jul 2020 13:17:50 -0600 From: Tom Tromey To: Fangrui Song via Gdb-patches Cc: Andrew Burgess , Fangrui Song Subject: Re: [PATCH v2] gdb: Recognize -1 as a tombstone value in .debug_line References: <20200630231842.508205-1-maskray@google.com> <20200701082605.GR2737@embecosm.com> <20200701173905.7znyf7jzhyatkpqx@google.com> X-Attribution: Tom Date: Wed, 01 Jul 2020 13:17:49 -0600 In-Reply-To: <20200701173905.7znyf7jzhyatkpqx@google.com> (Fangrui Song via Gdb-patches's message of "Wed, 1 Jul 2020 10:39:05 -0700") Message-ID: <87mu4j3uzm.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jqiEw-0018wZ-BV X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:51802 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jul 2020 19:18:02 -0000 >>>>> ">" == Fangrui Song via Gdb-patches writes: >> clang-format deletes space in `(CORE_ADDR) -1`. I think I need to adjust >> some options for my minimal .clang-format ... >> % cat .clang-format >> BasedOnStyle: GNU gdb doesn't use clang-format. I wrote a more comprehensive .clang-format once, as a test, but in the end I couldn't make it produce reasonable-looking output. In particular, long function calls were reformatted illegibly. >> + /* Linkers resolve a symbolic relocation referencing a GC'd function to 0 or >> + -1. If ADDRESS is 0, ignoring the opcode will err if the text section is Two spaces after the period. >> + located at 0x0. In this case, additionaly check that Same here. Also a typo, should be "additionally". This is ok with these fixed. Thank you for the patch. Tom