From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Limit default_target_compile override
Date: Fri, 19 Jun 2020 09:46:48 -0600 [thread overview]
Message-ID: <87mu4zxdlj.fsf@tromey.com> (raw)
In-Reply-To: <20200619120959.GA10641@delia> (Tom de Vries's message of "Fri, 19 Jun 2020 14:10:00 +0200")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> 2020-06-19 Tom de Vries <tdevries@suse.de>
Tom> * lib/gdb.exp (gdb_note): New proc.
Tom> * lib/future.exp (gdb_default_target_compile_1): Factor out of ...
Tom> (gdb_default_target_compile): ... here. Only call
Tom> gdb_default_target_compile_1 if use_gdb_compile(<lang>) is set.
Tom> (use_gdb_compile): Change to array.
Tom> (toplevel): Update sets of use_gdb_compile to specify language.
Tom> Warn about default_target_compile override. Store dejagnu's version
Tom> of default_target_compile in dejagnu_default_target_compile.
Thanks. This looks reasonable to me.
Tom> +set note_suffix ", using local override"
There are some extra spaces in this assignment.
Tom
next prev parent reply other threads:[~2020-06-19 15:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 12:10 Tom de Vries
2020-06-19 14:18 ` Tom de Vries
2020-06-19 15:46 ` Tom Tromey [this message]
2020-06-22 21:34 ` Luis Machado
2020-06-26 11:35 ` Luis Machado
2020-06-29 14:31 ` [PATCH][gdb/testsuite] Handle early_flags in gdb_default_target_compile Tom de Vries
2020-06-29 15:24 ` Aktemur, Tankut Baris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mu4zxdlj.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).