From: Tom Tromey <tromey@adacore.com>
To: Sergio Durigan Junior <sergiodj@sergiodj.net>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 3/4] Remove a use of target_read_string
Date: Mon, 15 Jun 2020 06:13:07 -0600 [thread overview]
Message-ID: <87mu54o7cc.fsf@tromey.com> (raw)
In-Reply-To: <877dwb8y3w.fsf@paluero> (Sergio Durigan Junior's message of "Fri, 12 Jun 2020 23:04:51 -0400")
>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@sergiodj.net> writes:
>> diff --git a/gdb/target.c b/gdb/target.c
>> index 14c494688e0..897b8fdd32b 100644
>> --- a/gdb/target.c
>> +++ b/gdb/target.c
>> @@ -50,6 +50,7 @@
>> #include "terminal.h"
>> #include <unordered_map>
>> #include "target-connection.h"
>> +#include "valprint.h"
>>
>> static void generic_tls_error (void) ATTRIBUTE_NORETURN;
Sergio> This hunk looks unrelated.
Oops, yeah -- this should be in one of the other patches.
I'll fix this.
Tom
next prev parent reply other threads:[~2020-06-15 12:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 21:53 [PATCH 0/4] Unify string-reading APIs Tom Tromey
2020-06-12 21:53 ` [PATCH 1/4] Remove read_memory_string Tom Tromey
2020-06-13 14:19 ` Simon Marchi
2020-06-15 12:37 ` Pedro Alves
2020-06-12 21:53 ` [PATCH 2/4] Rewrite target_read_string Tom Tromey
2020-06-12 21:53 ` [PATCH 3/4] Remove a use of target_read_string Tom Tromey
2020-06-13 3:04 ` Sergio Durigan Junior
2020-06-15 12:13 ` Tom Tromey [this message]
2020-06-12 21:53 ` [PATCH 4/4] Change target_read_string API Tom Tromey
2020-06-13 14:40 ` Simon Marchi
2020-06-13 14:40 ` [PATCH 0/4] Unify string-reading APIs Simon Marchi
2020-06-15 12:27 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mu54o7cc.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@sergiodj.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).