From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tromey@adacore.com>
Received: from rock.gnat.com (rock.gnat.com
 [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1])
 by sourceware.org (Postfix) with ESMTP id E324C384A033
 for <gdb-patches@sourceware.org>; Mon, 15 Jun 2020 12:13:10 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E324C384A033
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=adacore.com
Authentication-Results: sourceware.org;
 spf=pass smtp.mailfrom=tromey@adacore.com
Received: from localhost (localhost.localdomain [127.0.0.1])
 by filtered-rock.gnat.com (Postfix) with ESMTP id 58FB2117F9C;
 Mon, 15 Jun 2020 08:13:10 -0400 (EDT)
X-Virus-Scanned: Debian amavisd-new at gnat.com
Received: from rock.gnat.com ([127.0.0.1])
 by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024)
 with LMTP id GCepfNBhtTjG; Mon, 15 Jun 2020 08:13:10 -0400 (EDT)
Received: from murgatroyd (174-16-104-48.hlrn.qwest.net [174.16.104.48])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by rock.gnat.com (Postfix) with ESMTPSA id 6D996117435;
 Mon, 15 Jun 2020 08:13:08 -0400 (EDT)
From: Tom Tromey <tromey@adacore.com>
To: Sergio Durigan Junior <sergiodj@sergiodj.net>
Cc: Tom Tromey <tromey@adacore.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH 3/4] Remove a use of target_read_string
References: <20200612215356.22145-1-tromey@adacore.com>
 <20200612215356.22145-4-tromey@adacore.com> <877dwb8y3w.fsf@paluero>
X-Attribution: Tom
Date: Mon, 15 Jun 2020 06:13:07 -0600
In-Reply-To: <877dwb8y3w.fsf@paluero> (Sergio Durigan Junior's message of
 "Fri, 12 Jun 2020 23:04:51 -0400")
Message-ID: <87mu54o7cc.fsf@tromey.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, GIT_PATCH_0,
 KAM_DMARC_STATUS, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Jun 2020 12:13:15 -0000

>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@sergiodj.net> writes:

>> diff --git a/gdb/target.c b/gdb/target.c
>> index 14c494688e0..897b8fdd32b 100644
>> --- a/gdb/target.c
>> +++ b/gdb/target.c
>> @@ -50,6 +50,7 @@
>> #include "terminal.h"
>> #include <unordered_map>
>> #include "target-connection.h"
>> +#include "valprint.h"
>> 
>> static void generic_tls_error (void) ATTRIBUTE_NORETURN;

Sergio> This hunk looks unrelated.

Oops, yeah -- this should be in one of the other patches.
I'll fix this.

Tom