From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com [192.185.47.179]) by sourceware.org (Postfix) with ESMTPS id 596623851C00 for ; Thu, 14 May 2020 16:26:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 596623851C00 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 021676088 for ; Thu, 14 May 2020 11:26:47 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ZGh4jlzXKXVkQZGh4jsf7f; Thu, 14 May 2020 11:26:47 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0LF6YpqoIAbxztpiIauAFyVxPao6YVtLWucX1gpPgG8=; b=Lw0yMPzGwO0yK5mWjWeHwpXJio CGSzczuxbbaZJOfamWgjRDOKL7jPh8cqWa3n856ofcrsBtTvQ8nJ+qt5vJfdnoe9GRG6o/zrkL+45 gR7hylRjnvNnmhWF50qAlkNge; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:36770 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jZGh4-003lxU-MP; Thu, 14 May 2020 10:26:46 -0600 From: Tom Tromey To: Philippe Waroquiers via Gdb-patches Subject: Re: [RFA 07/10] Fix/improve 'help CLASS' output References: <20200510205530.21923-1-philippe.waroquiers@skynet.be> <20200510205530.21923-8-philippe.waroquiers@skynet.be> X-Attribution: Tom Date: Thu, 14 May 2020 10:26:46 -0600 In-Reply-To: <20200510205530.21923-8-philippe.waroquiers@skynet.be> (Philippe Waroquiers via Gdb-patches's message of "Sun, 10 May 2020 22:55:27 +0200") Message-ID: <87mu6a1nzt.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jZGh4-003lxU-MP X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:36770 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 May 2020 16:26:57 -0000 >>>>> "Philippe" == Philippe Waroquiers via Gdb-patches writes: Philippe> The output layout chosen is to have the command first, followed by all its Philippe> aliases separated by a comma. Note that the command and alias names are Philippe> title-styled. For sure, other layouts could be discussed, but this one is IMO Philippe> readable and compact. I think it's good this way. Philippe> +static void help_cmd_list (struct cmd_list_element *list, enum command_class theclass, This line looks to be too long. Philippe> - help_cmd_list (list, theclass, cmdtype, (int) theclass >= 0, stream); Philippe> + help_cmd_list (list, theclass, (int) theclass >= 0, stream); I think you might as well remove the "(int)" cast while you're touching this line. I don't believe it's needed. Otherwise this looks good to me. Tom