From: Tom Tromey <tom@tromey.com>
To: nitachra <Nitika.Achra@amd.com>
Cc: gdb-patches@sourceware.org, simark@simark.ca,
JiniSusan.George@amd.com, tom@tromey.com
Subject: Re: [PATCH v2 3/3] DWARFv5: Info address command error in gdb with DWARFfv5.
Date: Wed, 01 Apr 2020 13:24:41 -0600 [thread overview]
Message-ID: <87mu7v101y.fsf@tromey.com> (raw)
In-Reply-To: <20200330152136.18688-3-Nitika.Achra@amd.com> (nitachra's message of "Mon, 30 Mar 2020 20:51:36 +0530")
>>>>> ">" == nitachra <Nitika.Achra@amd.com> writes:
>> The length of location description is an unsigned ULEB integer in DWARFv5 instead of
>> unsigned integer.
I'd appreciate a reference to the section here.
Is it 2.6.2?
>> + if (dlbaton->per_cu->version () < 5)
>> + {
>> + length = extract_unsigned_integer (loc_ptr, 2, byte_order);
>> + loc_ptr += 2;
>> + }
>> + else
>> + {
>> + unsigned int bytes_read;
>> + length = read_unsigned_leb128 (NULL, loc_ptr, &bytes_read);
>> + loc_ptr += bytes_read;
>> + }
The formatting looks off here. See the GNU standards, or the examples
elsewhere in this file, to see how it should be done.
Tom
next prev parent reply other threads:[~2020-04-01 19:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 15:21 [PATCH v2 1/3] Support for DW_AT_loclists_base and DW_FORM_loclistx nitachra
2020-03-30 15:21 ` [PATCH v2 2/3] DWARFv5: Handle location list for split dwarf nitachra
2020-03-30 15:21 ` [PATCH v2 3/3] DWARFv5: Info address command error in gdb with DWARFfv5 nitachra
2020-04-01 19:24 ` Tom Tromey [this message]
2020-03-30 16:07 ` [PATCH v2 1/3] Support for DW_AT_loclists_base and DW_FORM_loclistx Simon Marchi
2020-04-01 19:16 ` Tom Tromey
-- strict thread matches above, loose matches on Subject: below --
2020-04-03 15:01 [PATCH v2 3/3] DWARFv5: Info address command error in gdb with DWARFfv5 nitachra
2020-04-03 17:49 ` Tom Tromey
2020-03-29 16:07 [PATCH v2 1/3] Support for DW_AT_loclists_base and DW_FORM_loclistx nitachra
2020-03-29 16:07 ` [PATCH v2 3/3] DWARFv5: Info address command error in gdb with DWARFfv5 nitachra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mu7v101y.fsf@tromey.com \
--to=tom@tromey.com \
--cc=JiniSusan.George@amd.com \
--cc=Nitika.Achra@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).