From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26796 invoked by alias); 19 Dec 2019 20:27:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26788 invoked by uid 89); 19 Dec 2019 20:27:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:579 X-HELO: gateway23.websitewelcome.com Received: from gateway23.websitewelcome.com (HELO gateway23.websitewelcome.com) (192.185.49.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Dec 2019 20:27:27 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway23.websitewelcome.com (Postfix) with ESMTP id C477E108075 for ; Thu, 19 Dec 2019 14:27:25 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id i2OLiZbM8OdBHi2OLih8gT; Thu, 19 Dec 2019 14:27:25 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LR3N7qsV/MYxQ/zIDDc4g/QKCMj9c+wzPO4GJ98VLts=; b=pTzCY8zjIFn2EyQ4+c5zz+X+sV KAfptiCx3BcfT+NQwKXlKa+Pv0XfLbBeSQFBRigSFFTVIjTGjCGzmx7RkeoqthmtMuUr8KM0Ytyh/ x5kROe12FlUqSyjLAVdGVo2Nz; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:38918 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1ii2OL-001nl2-Jd; Thu, 19 Dec 2019 13:27:25 -0700 From: Tom Tromey To: Weimin Pan Cc: gdb-patches@sourceware.org, tom@tromey.com Subject: Re: [PATCH v5] gdb: CTF support update References: <1575597618-20336-1-git-send-email-weimin.pan@oracle.com> Date: Thu, 19 Dec 2019 20:27:00 -0000 In-Reply-To: <1575597618-20336-1-git-send-email-weimin.pan@oracle.com> (Weimin Pan's message of "Thu, 5 Dec 2019 21:00:18 -0500") Message-ID: <87mubo83ir.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-12/txt/msg00839.txt.bz2 >>>>> Weimin Pan writes: > This patch addresses Tom Tromey's comments on the CTF reader: > * Use the type-safe registry for ctf_file_key; > * Drop "typedef" when defining "struct ctf_context"; > * Use ANOFFSET with SECT_OFF_TEXT to get the text base address; Thanks for the patch. > +struct ctf_fp_info > + { This brace should be in the leftmost column. > + ctf_fp_info (ctf_file_t *cfp) : fp (cfp) {} Single-argument constructors should be marked "explicit". This patch is ok with these fixes. Thanks. Tom