public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: Tom Tromey <tom@tromey.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH 0/8] Upgrade readline
Date: Wed, 07 Aug 2019 19:31:00 -0000	[thread overview]
Message-ID: <87mugk7oy0.fsf@tromey.com> (raw)
In-Reply-To: <874l2tdjha.fsf@redhat.com> (Sergio Durigan Junior's message of	"Wed, 07 Aug 2019 12:32:33 -0400")

>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:

Sergio> I'm in favour of bumping the readline version to 7 (note that Debian
Sergio> oldstable, i.e., wheezy, which was released 4+ years ago, already ships
Sergio> with readline 7), and (eventually) just get rid of our local copy.

We talked about that briefly on irc yesterday too.

I wonder if we really could get rid of the local copy.  I mean,
obviously we could, but would it be a problem for anybody?

We could treat it a few ways.  One would be like libiconv: keep the
top-level configury around so it's possible to drop the readline sources
into the tree and then build.

Another way would be to use something like guix for these dependencies.
I don't know if that works on all the hosts that we care about.

The guix way is attractive since it seems vaguely analogous to using
"cargo" in the Rust world.  In particular if we could do something like
this, maybe we could be less conservative about bringing in new
dependencies.


I think either of these solutions would also fix the bug we found with
moving gdbsupport to the top level (i.e. that it interacts poorly with
--with-system-readline).  (I never got a response to that note, so if
you're reading this, I'd appreciate a quick look at that as well.)

thanks,
Tom

  reply	other threads:[~2019-08-07 19:31 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-06 20:43 Tom Tromey
2019-08-06 20:43 ` [PATCH 4/8] Remove gdb workaround from readline/xfree.c Tom Tromey
2019-08-06 20:43 ` [PATCH 2/8] Remove gdb workaround from readline/complete.c Tom Tromey
2019-08-06 20:43 ` [PATCH 8/8] Require readline 7 or newer Tom Tromey
2019-08-07  2:27   ` Eli Zaretskii
2019-08-07 14:42   ` Pedro Alves
2019-08-07 22:31     ` Tom Tromey
2019-08-08  2:37       ` Eli Zaretskii
2019-08-08 11:26       ` Pedro Alves
2019-08-08 11:29       ` Pedro Alves
2019-08-08 20:38         ` Tom Tromey
2019-08-07 14:45   ` Pedro Alves
2019-08-06 20:43 ` [PATCH 5/8] Fix gdb's selftest.exp after readline import Tom Tromey
2019-08-13 17:02   ` [committed][gdb/testsuite] Fix gdb.gdb/selftest.exp regexp Tom de Vries
2019-08-06 20:43 ` [PATCH 3/8] Remove gdb workaround from readline/emacs_keymap.c Tom Tromey
2019-08-06 20:43 ` [PATCH 7/8] Remove readline hack from gdb_select Tom Tromey
2019-08-07 14:29   ` Pedro Alves
2019-08-07 22:03     ` Tom Tromey
2019-08-07 22:16       ` Christian Biesinger via gdb-patches
2019-08-07  3:05 ` [PATCH 0/8] Upgrade readline Kevin Buettner
2019-08-07 13:38   ` Tom Tromey
2019-08-07 13:40   ` Tom Tromey
2019-08-14 10:21     ` Tom de Vries
2019-08-15 13:46       ` Tom Tromey
2019-08-19 16:38         ` Tom de Vries
2019-08-07 16:32 ` Sergio Durigan Junior
2019-08-07 19:31   ` Tom Tromey [this message]
2019-08-12 19:46     ` Sergio Durigan Junior
2019-08-12 19:52       ` Christian Biesinger via gdb-patches
2019-08-12 16:57 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mugk7oy0.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sergiodj@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).