From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12110 invoked by alias); 30 Apr 2019 15:06:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12063 invoked by uid 89); 30 Apr 2019 15:06:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,UNSUBSCRIBE_BODY autolearn=no version=3.3.1 spammy=TRANSCRIPT X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.144.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Apr 2019 15:06:30 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 242A4226C for ; Tue, 30 Apr 2019 10:06:28 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id LUKyhpukX4FKpLUKyhGdAp; Tue, 30 Apr 2019 10:06:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kEpeR6ouIy8Vr3jmCjhfmX30Qh468QJBec+2fOW1ksY=; b=YyiSPxEb5j6fSbl9RSEaX4Eo/c l/BMkHsdvKH/AxaWPnYMB6mORtfFIJ2AbaIg7YYMyK1BzpuZzsNo4dvw5t/KSukBGAjkAozKHbP+Z t5y8ydhuv6ZftQ6RtrHTx9JhG; Received: from 97-122-168-123.hlrn.qwest.net ([97.122.168.123]:43020 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hLUKx-002hJ6-SR; Tue, 30 Apr 2019 10:06:27 -0500 From: Tom Tromey To: Alan Hayward Cc: "gdb-patches\@sourceware.org" , nd Subject: Re: [PATCH] testsuite: Record all gdb input to gdb.in References: <20190429160736.34276-1-alan.hayward@arm.com> Date: Tue, 30 Apr 2019 15:06:00 -0000 In-Reply-To: <20190429160736.34276-1-alan.hayward@arm.com> (Alan Hayward's message of "Mon, 29 Apr 2019 16:08:19 +0000") Message-ID: <87muk7353g.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-04/txt/msg00649.txt.bz2 >>>>> "Alan" == Alan Hayward writes: Alan> Once a test has been run, the .in file can be used to re-run the test in the Alan> following way: Alan> gdb -x outputs/gdb.store/gdb.in outputs/gdb.store/store Alan> Note, this functionality is ALWAYS on when running a test. I considered this Alan> would be more useful than making it optional. I think it probably makes sense to delete the existing TRANSCRIPT code when doing this. Alan> + # First time opening. Alan> + set in_file_count 0 Alan> + set logfile [standard_output_file gdb.in] Does anything ever reset in_file_count? Or if you run a bunch of test cases, will the number just keep incrementing? Alan> + switch -regexp -- $type { Why -regexp? Alan> + #Write to the log Space after the "#". Alan> + puts -nonewline $in_file "$message" It may be good for this code to catch errors, not sure though. Tom