From: Tom Tromey <tom@tromey.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA/commit] (Ada) fix GDB crash printing packed array
Date: Fri, 15 Feb 2019 19:49:00 -0000 [thread overview]
Message-ID: <87mumwzvad.fsf@tromey.com> (raw)
In-Reply-To: <1549786901-77868-1-git-send-email-brobecker@adacore.com> (Joel Brobecker's message of "Sun, 10 Feb 2019 03:21:41 -0500")
>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:
Joel> (1) Forcing the lookup into language_c currently does not affect
Joel> how symbol matching is done anymore, because we look at the symbol's
Joel> language to determine which kind of matching should be done;
There's also this code in get_symbol_name_matcher:
/* If currently in Ada mode, and the lookup name is wrapped in
'<...>', hijack all symbol name comparisons using the Ada
matcher, which handles the verbatim matching. */
if (current_language->la_language == language_ada
&& lookup_name.ada ().verbatim_p ())
return current_language->la_get_symbol_name_matcher (lookup_name);
I don't know if this could be removed, but if so it would be better to
do so.
The patch looks fine to me.
Tom
next prev parent reply other threads:[~2019-02-15 19:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-10 8:21 Joel Brobecker
2019-02-15 19:49 ` Tom Tromey [this message]
2019-02-17 13:34 ` Joel Brobecker
2019-05-10 20:51 ` Pedro Franco de Carvalho
2019-05-11 17:23 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mumwzvad.fsf@tromey.com \
--to=tom@tromey.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).