From: Tom Tromey <tom@tromey.com>
To: Gary Benson <gbenson@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Fix resource leak found by Coverity
Date: Wed, 10 Oct 2018 16:02:00 -0000 [thread overview]
Message-ID: <87murleqnv.fsf@tromey.com> (raw)
In-Reply-To: <1539176277-4500-2-git-send-email-gbenson@redhat.com> (Gary Benson's message of "Wed, 10 Oct 2018 13:57:56 +0100")
>>>>> "Gary" == Gary Benson <gbenson@redhat.com> writes:
Gary> This commit fixes a resource leak found by Coverity, where cli_interp's
Gary> constructor creates a new cli_ui_out, but there was no corresponding
Gary> destructor to free it.
Same deal with the patch title.
Gary> * cli/cli-interp.c (cli_interp::~cli_interp): New function.
I wonder if it's possible for the ui-out to be used after the
interpreter is destroyed. A simple check with valgrind would show that,
I think.
This is ok if that succeeds.
Tom
next prev parent reply other threads:[~2018-10-10 16:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 12:58 [PATCH 0/2] Fix resource leaks " Gary Benson
2018-10-10 12:58 ` [PATCH 1/2] Fix resource leak " Gary Benson
2018-10-10 16:02 ` Tom Tromey [this message]
2018-10-10 12:58 ` [PATCH 2/2] " Gary Benson
2018-10-10 16:01 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87murleqnv.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).