From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29778 invoked by alias); 10 Oct 2018 16:02:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29725 invoked by uid 89); 10 Oct 2018 16:02:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=destroyed X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 Oct 2018 16:02:15 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway33.websitewelcome.com (Postfix) with ESMTP id AE080760EA9 for ; Wed, 10 Oct 2018 11:02:13 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id AGw9g5Kw1aSeyAGw9gRJfy; Wed, 10 Oct 2018 11:02:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=suFbEPWmIFRvFBAFFc7o3RALxXqeZ1CGqESGVOUGohU=; b=qRcUwrM5RpgpPfm3Ou4KCus3Jn 0Ipn4JrH671l7KBpaNHd74y4Cg9SwPUyBHDGDuM4gYKhwaT6pa2VvTLI9sPIjy0ErEWzVdq6bvIGc 86MWiX9heaqSrXF7+jJBpY44W; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:37524 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gAGw9-002A0B-C5; Wed, 10 Oct 2018 11:02:13 -0500 From: Tom Tromey To: Gary Benson Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] Fix resource leak found by Coverity References: <1539176277-4500-1-git-send-email-gbenson@redhat.com> <1539176277-4500-2-git-send-email-gbenson@redhat.com> Date: Wed, 10 Oct 2018 16:02:00 -0000 In-Reply-To: <1539176277-4500-2-git-send-email-gbenson@redhat.com> (Gary Benson's message of "Wed, 10 Oct 2018 13:57:56 +0100") Message-ID: <87murleqnv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-10/txt/msg00264.txt.bz2 >>>>> "Gary" == Gary Benson writes: Gary> This commit fixes a resource leak found by Coverity, where cli_interp's Gary> constructor creates a new cli_ui_out, but there was no corresponding Gary> destructor to free it. Same deal with the patch title. Gary> * cli/cli-interp.c (cli_interp::~cli_interp): New function. I wonder if it's possible for the ui-out to be used after the interpreter is destroyed. A simple check with valgrind would show that, I think. This is ok if that succeeds. Tom