From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69387 invoked by alias); 28 Aug 2018 22:40:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69202 invoked by uid 89); 28 Aug 2018 22:40:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway32.websitewelcome.com Received: from gateway32.websitewelcome.com (HELO gateway32.websitewelcome.com) (192.185.145.189) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Aug 2018 22:40:10 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway32.websitewelcome.com (Postfix) with ESMTP id 978EA2697B2 for ; Tue, 28 Aug 2018 17:40:08 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id umeUf9uH4BcCXumeafeGqw; Tue, 28 Aug 2018 17:40:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ejnt08C5wc/Tt93QCGRE0RGPzfr0dxjJlaB56sMeptw=; b=xhAgyQkiaRbPGFoyeVIuKvhLMa IYtzbEPqhrSKgE0KM3iaivF+N55qaAmFEWEi0asI04AIgcTB7OLOPazTvh5YoRgrzcQVQi60TZhBP UYDlHHrJN0nM7VIDcrZUgawkD; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:44684 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fumeT-003Bfq-Mj; Tue, 28 Aug 2018 17:39:57 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Subject: Re: [PATCH 1/9] Do not pass NULL to memcpy References: <20180827145620.11055-1-tom@tromey.com> <20180827145620.11055-2-tom@tromey.com> <5b410119-aae4-6911-f493-6d2c79e5c49e@ericsson.com> Date: Tue, 28 Aug 2018 22:40:00 -0000 In-Reply-To: <5b410119-aae4-6911-f493-6d2c79e5c49e@ericsson.com> (Simon Marchi's message of "Mon, 27 Aug 2018 15:11:56 -0400") Message-ID: <87mut6xghv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00716.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> While the patch does not look wrong, I think the problem would "solve itself" Simon> "reg" was an std::vector, since an std::vector already has an appropriate copy Simon> constructor. It would also simplify a lot this area of the code, for example, Simon> the alloc_regs method would become a one-liner. I did this and I'll include it as a separate patch in the next round. Tom