From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] Eliminate the 'the_core_target' global
Date: Fri, 04 May 2018 15:59:00 -0000 [thread overview]
Message-ID: <87muxf2yzj.fsf@tromey.com> (raw)
In-Reply-To: <20180503162234.15371-3-palves@redhat.com> (Pedro Alves's message of "Thu, 3 May 2018 17:22:33 +0100")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> Currently, core_file_command calls 'the_core_target->detach()' even if
Pedro> the core target is not open and pushed on the target stack. If it is
Pedro> indeed not open, then the practical effect is that
Pedro> core_target::detach() prints "No core file now.". That is preserved
Pedro> by printing that directly from within core_file_command if not
Pedro> debugging a core.
I read this patch & it seemed fine to me.
Tom
next prev parent reply other threads:[~2018-05-04 15:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 16:22 [PATCH 0/3] Torward multiple simultaneous core instances Pedro Alves
2018-05-03 16:22 ` [PATCH 3/3] Heap-allocate core_target instances Pedro Alves
2018-05-04 16:36 ` Tom Tromey
2018-05-06 15:38 ` Pedro Alves
2018-05-07 14:26 ` Tom Tromey
2018-05-11 19:40 ` Pedro Alves
2018-05-03 16:22 ` [PATCH 2/3] Eliminate the 'the_core_target' global Pedro Alves
2018-05-04 15:59 ` Tom Tromey [this message]
2018-05-03 16:22 ` [PATCH 1/3] Move core_bfd to program space Pedro Alves
2018-05-04 15:41 ` Tom Tromey
2018-05-04 16:09 ` Pedro Alves
2018-05-04 16:46 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muxf2yzj.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).