From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 535 invoked by alias); 4 May 2018 15:59:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 526 invoked by uid 89); 4 May 2018 15:59:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:544 X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.149.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 04 May 2018 15:59:30 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 7E9CE2625C6 for ; Fri, 4 May 2018 10:59:29 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Ed7JfhOr15CKDEd7JfDiF5; Fri, 04 May 2018 10:59:29 -0500 X-Authority-Reason: nr=8 Received: from 97-122-176-117.hlrn.qwest.net ([97.122.176.117]:45570 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fEd7J-002HA5-8m; Fri, 04 May 2018 10:59:29 -0500 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] Eliminate the 'the_core_target' global References: <20180503162234.15371-1-palves@redhat.com> <20180503162234.15371-3-palves@redhat.com> Date: Fri, 04 May 2018 15:59:00 -0000 In-Reply-To: <20180503162234.15371-3-palves@redhat.com> (Pedro Alves's message of "Thu, 3 May 2018 17:22:33 +0100") Message-ID: <87muxf2yzj.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fEd7J-002HA5-8m X-Source-Sender: 97-122-176-117.hlrn.qwest.net (pokyo) [97.122.176.117]:45570 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-05/txt/msg00092.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> Currently, core_file_command calls 'the_core_target->detach()' even if Pedro> the core target is not open and pushed on the target stack. If it is Pedro> indeed not open, then the practical effect is that Pedro> core_target::detach() prints "No core file now.". That is preserved Pedro> by printing that directly from within core_file_command if not Pedro> debugging a core. I read this patch & it seemed fine to me. Tom