From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Eliminate target_ops::to_xclose
Date: Fri, 27 Apr 2018 15:24:00 -0000 [thread overview]
Message-ID: <87muxo65ap.fsf@tromey.com> (raw)
In-Reply-To: <20180413175700.19109-1-palves@redhat.com> (Pedro Alves's message of "Fri, 13 Apr 2018 18:57:00 +0100")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> In the multi-target branch, I found no need for the target_close vs
Pedro> target_xclose distinction. Heap-allocated targets simply delete
Pedro> themselves in their target_close implementation, while
Pedro> singleton/static targets don't.
Pedro> The target_ops C++ification patches will add more commentary around
Pedro> target_ops's destructor, but there's no destructor yet...
This looks good to me and it seems like the close/xclose distinction
already doesn't really make sense anyway.
Tom
next prev parent reply other threads:[~2018-04-27 15:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 17:57 Pedro Alves
2018-04-27 15:24 ` Tom Tromey [this message]
2018-05-03 0:00 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muxo65ap.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).