From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52353 invoked by alias); 27 Apr 2018 15:24:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51862 invoked by uid 89); 27 Apr 2018 15:24:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:608 X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.51.110) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 27 Apr 2018 15:24:40 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway24.websitewelcome.com (Postfix) with ESMTP id A126045B395 for ; Fri, 27 Apr 2018 10:24:31 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id C5EdfkCJDA3CSC5EdfpZan; Fri, 27 Apr 2018 10:24:31 -0500 X-Authority-Reason: nr=8 Received: from 97-122-176-117.hlrn.qwest.net ([97.122.176.117]:60874 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fC5Ed-000ypJ-Bu; Fri, 27 Apr 2018 10:24:31 -0500 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Eliminate target_ops::to_xclose References: <20180413175700.19109-1-palves@redhat.com> Date: Fri, 27 Apr 2018 15:24:00 -0000 In-Reply-To: <20180413175700.19109-1-palves@redhat.com> (Pedro Alves's message of "Fri, 13 Apr 2018 18:57:00 +0100") Message-ID: <87muxo65ap.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fC5Ed-000ypJ-Bu X-Source-Sender: 97-122-176-117.hlrn.qwest.net (pokyo) [97.122.176.117]:60874 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-04/txt/msg00568.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> In the multi-target branch, I found no need for the target_close vs Pedro> target_xclose distinction. Heap-allocated targets simply delete Pedro> themselves in their target_close implementation, while Pedro> singleton/static targets don't. Pedro> The target_ops C++ification patches will add more commentary around Pedro> target_ops's destructor, but there's no destructor yet... This looks good to me and it seems like the close/xclose distinction already doesn't really make sense anyway. Tom