From: Tom Tromey <tom@tromey.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 5/6] Remove objfile argument from add_dyn_prop
Date: Wed, 10 Jan 2018 16:32:00 -0000 [thread overview]
Message-ID: <87mv1lisjj.fsf@tromey.com> (raw)
In-Reply-To: <86wp0pg95s.fsf@gmail.com> (Yao Qi's message of "Wed, 10 Jan 2018 13:01:19 +0000")
>>>>> "Yao" == Yao Qi <qiyaoltc@gmail.com> writes:
Yao> Tom Tromey <tom@tromey.com> writes:
>> @@ -25116,7 +25116,7 @@ set_die_type (struct die_info *die, struct type *type, struct dwarf2_cu *cu)
>> if (attr_form_is_block (attr))
>> {
>> if (attr_to_dynamic_prop (attr, die, cu, &prop))
>> - add_dyn_prop (DYN_PROP_ALLOCATED, prop, type, objfile);
>> + add_dyn_prop (DYN_PROP_ALLOCATED, prop, type);
>> }
Yao> Before the patch, the objfile is
Yao> cu-> per_cu->dwarf2_per_objfile->objfile, but after the patch, the
Yao> objfile is TYPE_OBJFILE (type), are they equivalent?
If they were not the same, then that was already a bug, because
types generally have the restriction that they can only point to static
data or to other objects allocated on the same objfile. Cross-objfile
pointers are not allowed, to avoid dangling pointers when an objfile is
destroyed.
Now, a given invocation of the DWARF reader generally deals with a
single objfile. So I believe they were the same. But if they were not,
then this patch actually improves the situation.
Tom
next prev parent reply other threads:[~2018-01-10 16:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-06 0:26 [RFA 0/6] Some DWARF reader polishing Tom Tromey
2018-01-06 0:26 ` [RFA 2/6] Allocate abbrev_table with new Tom Tromey
2018-01-07 5:29 ` Simon Marchi
2018-01-07 16:55 ` Simon Marchi
2018-01-09 18:56 ` Tom Tromey
2018-01-10 12:02 ` Yao Qi
2018-01-10 16:10 ` Tom Tromey
2018-01-10 12:45 ` Simon Marchi
2018-01-06 0:26 ` [RFA 4/6] Change dwarf2_cu::method_info to be a std::vector Tom Tromey
2018-01-16 15:30 ` Simon Marchi
2018-01-17 17:15 ` Tom Tromey
2018-01-17 17:29 ` Simon Marchi
2018-01-06 0:26 ` [RFA 1/6] Unify new_symbol and new_symbol_full Tom Tromey
2018-01-07 5:33 ` Simon Marchi
2018-01-06 0:26 ` [RFA 3/6] Allocate dwarf2_cu with new Tom Tromey
2018-01-10 12:17 ` Yao Qi
2018-01-10 16:14 ` Tom Tromey
2018-01-10 16:28 ` Tom Tromey
2018-01-16 15:04 ` Simon Marchi
2018-01-17 17:10 ` Tom Tromey
2018-01-06 0:26 ` [RFA 5/6] Remove objfile argument from add_dyn_prop Tom Tromey
2018-01-10 13:01 ` Yao Qi
2018-01-10 16:32 ` Tom Tromey [this message]
2018-01-16 16:00 ` Yao Qi
2018-01-16 15:33 ` Simon Marchi
2018-01-17 17:16 ` Tom Tromey
2018-01-06 0:26 ` [RFA 6/6] Remove symbolp typedef Tom Tromey
2018-01-16 15:33 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mv1lisjj.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).