From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <palves@redhat.com>
Cc: Sergio Durigan Junior <sergiodj@redhat.com>,
GDB Patches <gdb-patches@sourceware.org>,
Joel Brobecker <brobecker@adacore.com>,
Yao Qi <qiyaoltc@gmail.com>, Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH v4] Add support for the readnever concept
Date: Fri, 01 Dec 2017 17:19:00 -0000 [thread overview]
Message-ID: <87mv325pz8.fsf@tromey.com> (raw)
In-Reply-To: <d912d6af-2500-56bc-5e40-a048c2dbd9e9@redhat.com> (Pedro Alves's message of "Fri, 1 Dec 2017 12:43:06 +0000")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> On 12/01/2017 04:35 AM, Sergio Durigan Junior wrote:
>>> If readnever_symbol_files is set, then it'll have been propagated to
objfile-> flags before we get here, no?
>>
>> Hm, I think so, yes. I mean, assuming that objfile != NULL when we call
>> the readers, then yes;
Pedro> Certainly you can assume that. A reader's job is to read
Pedro> in the passed in objfile. The very first line of elf_symfile_read
Pedro> would immediately crash otherwise, for example.
Perhaps an ATTRIBUTE_NONNULL is in order somewhere.
Tom
next prev parent reply other threads:[~2017-12-01 17:19 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 20:54 [RFC/RFA] Add support for the --readnever command-line option (DWARF only) Joel Brobecker
2016-07-12 14:27 ` Yao Qi
2016-10-04 18:07 ` Pedro Alves
2017-11-23 0:54 ` [PATCH v2] " Sergio Durigan Junior
2017-11-23 12:09 ` Pedro Alves
2017-11-23 17:21 ` Sergio Durigan Junior
2017-11-23 17:29 ` Pedro Alves
2017-11-24 4:54 ` Sergio Durigan Junior
2017-11-24 13:18 ` Pedro Alves
2017-11-24 20:27 ` Sergio Durigan Junior
2017-11-27 19:13 ` Pedro Alves
2017-11-29 0:59 ` Sergio Durigan Junior
2017-11-29 12:23 ` Pedro Alves
2017-11-23 15:59 ` Eli Zaretskii
2017-11-23 19:36 ` Sergio Durigan Junior
2016-10-04 18:06 ` [RFC/RFA] " Pedro Alves
2017-11-24 23:01 ` [PATCH v2] Add support for the --readnever command-line option Sergio Durigan Junior
2017-11-25 7:33 ` Eli Zaretskii
2017-11-25 16:41 ` Sergio Durigan Junior
2017-11-25 17:16 ` Eli Zaretskii
2017-11-29 1:21 ` [PATCH v3] Add support for the readnever concept Sergio Durigan Junior
2017-11-29 3:39 ` Eli Zaretskii
2017-11-29 12:25 ` Pedro Alves
2017-11-29 18:43 ` Sergio Durigan Junior
2017-11-29 21:45 ` [PATCH] Make 'symbol-file' not care about the position of command line arguments Sergio Durigan Junior
2017-11-29 22:26 ` Pedro Alves
2017-11-29 22:42 ` Sergio Durigan Junior
2017-11-29 23:15 ` Pedro Alves
2017-11-30 0:08 ` Sergio Durigan Junior
2017-11-30 0:34 ` Pedro Alves
2017-11-30 4:07 ` Sergio Durigan Junior
2017-11-30 4:25 ` [PATCH v2] Make '{add-,}symbol-file' " Sergio Durigan Junior
2017-11-30 10:57 ` Pedro Alves
2017-11-30 12:38 ` Sergio Durigan Junior
2017-11-30 12:49 ` Pedro Alves
2017-11-30 13:06 ` Sergio Durigan Junior
2017-11-30 13:33 ` [PATCH v3] " Sergio Durigan Junior
2017-11-30 15:01 ` Pedro Alves
2017-11-30 17:26 ` Sergio Durigan Junior
2017-11-30 17:37 ` Pedro Alves
2017-11-30 17:43 ` Sergio Durigan Junior
2017-11-30 17:50 ` Pedro Alves
2017-11-30 20:00 ` [PATCH v4] " Sergio Durigan Junior
2017-12-01 12:11 ` Pedro Alves
2017-12-01 17:41 ` Sergio Durigan Junior
2017-12-01 21:45 ` Pedro Alves
2017-12-01 22:02 ` Sergio Durigan Junior
2017-11-30 0:25 ` [PATCH v4] Add support for the readnever concept Sergio Durigan Junior
2017-11-30 11:53 ` Pedro Alves
2017-12-01 4:35 ` Sergio Durigan Junior
2017-12-01 12:43 ` Pedro Alves
2017-12-01 17:19 ` Tom Tromey [this message]
2017-12-01 17:21 ` Sergio Durigan Junior
2017-12-01 20:00 ` Pedro Alves
2017-12-01 22:16 ` [PATCH v5] " Sergio Durigan Junior
2017-12-01 23:19 ` Pedro Alves
2017-12-02 2:31 ` Sergio Durigan Junior
2017-12-02 8:21 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mv325pz8.fsf@tromey.com \
--to=tom@tromey.com \
--cc=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=qiyaoltc@gmail.com \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).