From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70158 invoked by alias); 14 Oct 2016 21:33:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 70145 invoked by uid 89); 14 Oct 2016 21:33:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: gproxy4-pub.mail.unifiedlayer.com Received: from gproxy4-pub.mail.unifiedlayer.com (HELO gproxy4-pub.mail.unifiedlayer.com) (69.89.23.142) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Fri, 14 Oct 2016 21:33:14 +0000 Received: (qmail 5419 invoked by uid 0); 14 Oct 2016 21:33:12 -0000 Received: from unknown (HELO CMOut01) (10.0.90.82) by gproxy4.mail.unifiedlayer.com with SMTP; 14 Oct 2016 21:33:12 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by CMOut01 with id vZZ71t0162f2jeq01ZZATc; Fri, 14 Oct 2016 15:33:10 -0600 X-Authority-Analysis: v=2.1 cv=beT4Do/B c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=CH0kA5CcgfcA:10 a=20KFwNOVAAAA:8 a=aTI9UQUnQTOQnoZorO8A:9 a=e_O65bzb51kRm2y5VmPK:22 Received: from 174-16-143-211.hlrn.qwest.net ([174.16.143.211]:35750 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1bvA6H-0005n5-CB; Fri, 14 Oct 2016 15:33:09 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA v2 02/17] Use scoped_restore for ui_file References: <1476393012-29987-1-git-send-email-tom@tromey.com> <1476393012-29987-3-git-send-email-tom@tromey.com> <88d4c1e5-170d-a981-ba8b-484b447613e6@redhat.com> Date: Fri, 14 Oct 2016 21:33:00 -0000 In-Reply-To: <88d4c1e5-170d-a981-ba8b-484b447613e6@redhat.com> (Pedro Alves's message of "Thu, 13 Oct 2016 23:07:01 +0100") Message-ID: <87mvi6lipa.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1bvA6H-0005n5-CB X-Source-Sender: 174-16-143-211.hlrn.qwest.net (bapiya) [174.16.143.211]:35750 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-10/txt/msg00464.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> I wonder if aligning like: Pedro> scoped_restore save_stdout Pedro> = make_scoped_restore (&gdb_stdout, str_file); Pedro> scoped_restore save_stderr Pedro> = make_scoped_restore (&gdb_stderr, str_file); Pedro> scoped_restore save_stdlog Pedro> = make_scoped_restore (&gdb_stdlog, str_file); Pedro> scoped_restore save_stdtarg Pedro> = make_scoped_restore (&gdb_stdtarg, str_file); Pedro> scoped_restore save_stdtargerr Pedro> = make_scoped_restore (&gdb_stdtargerr, str_file); Pedro> would read better. Can't tell on the mail client. Pedro> Up to you; just a thought. I think so. I went ahead and made this change. Tom