From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124201 invoked by alias); 23 Jul 2015 18:42:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124187 invoked by uid 89); 23 Jul 2015 18:42:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 23 Jul 2015 18:42:12 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 5AF7737C819; Thu, 23 Jul 2015 18:42:11 +0000 (UTC) Received: from localhost (unused-10-15-17-51.yyz.redhat.com [10.15.17.51]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t6NIgAS4003449 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 23 Jul 2015 14:42:11 -0400 From: Sergio Durigan Junior To: Patrick Palka Cc: gdb-patches@sourceware.org Subject: Racy failures on gdb.base/gdbinit-history.exp (native-extended-gdbserver/-m64) (was: Re: [PATCH] Don't truncate the history file when history size is unlimited) References: <1433878062-23560-1-git-send-email-patrick@parcs.ath.cx> <1434466413-28892-1-git-send-email-patrick@parcs.ath.cx> X-URL: http://blog.sergiodj.net Date: Thu, 23 Jul 2015 18:42:00 -0000 In-Reply-To: <1434466413-28892-1-git-send-email-patrick@parcs.ath.cx> (Patrick Palka's message of "Tue, 16 Jun 2015 10:53:33 -0400") Message-ID: <87mvym67i5.fsf_-_@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-07/txt/msg00660.txt.bz2 On Tuesday, June 16 2015, Patrick Palka wrote: > We still do not handle "set history size unlimited" correctly. In > particular, after writing to the history file, we truncate the history > even if it is unlimited. > > This patch makes sure that we do not call history_truncate_file() if the > history is not stifled (i.e. if it's unlimited). This bug causes the > history file to be truncated to zero on exit when one has "set history > size unlimited" in their gdbinit file. Although this code exists in GDB > 7.8, the bug is masked by a pre-existing bug that's been only fixed in > GDB 7.9 (PR gdb/17820). Hey Patrick, Looking at the BuildBot logs today, I found that this new test is failing occasionally on native-extended-gdbserver testing. Take a look at the following build: You can see that gdb.base/gdbinit-history.exp failed: PASS -> FAIL: gdb.base/gdbinit-history.exp: truncation: appending: server show commands PASS -> FAIL: gdb.base/gdbinit-history.exp: truncation: creating: server show commands The gdb.log is here: I haven't really investigated to determine what's going on here, but let me know if you need any help with this. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/