From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-112476-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 2484 invoked by alias); 16 May 2014 20:31:01 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 2473 invoked by uid 89); 16 May 2014 20:31:00 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 May 2014 20:30:59 +0000
Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4GKUuFU007136	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);	Fri, 16 May 2014 16:30:56 -0400
Received: from barimba (ovpn-113-182.phx2.redhat.com [10.3.113.182])	by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4GKUksb004138	(version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO);	Fri, 16 May 2014 16:30:55 -0400
From: Tom Tromey <tromey@redhat.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH v5] Exit code of exited inferiors in -list-thread-groups
References: <1400018204-29559-1-git-send-email-simon.marchi@ericsson.com>
Date: Fri, 16 May 2014 20:31:00 -0000
In-Reply-To: <1400018204-29559-1-git-send-email-simon.marchi@ericsson.com>	(Simon Marchi's message of "Tue, 13 May 2014 17:56:44 -0400")
Message-ID: <87mweh31qi.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2014-05/txt/msg00314.txt.bz2

>>>>> "Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:

Simon> This one was also from a year ago, I would like to make sure it is still
Simon> OK.

Simon> +      if (inferior->has_exit_code)
Simon> +	ui_out_field_string (uiout, "exit-code",
Simon> +			     int_string (inferior->exit_code, 8, 0, 0, 1));

Why not the simpler ui_out_field_int?
Going out of the way to print it in octal seems a bit odd for a machine
interface.

Tom