From: Tom Tromey <tromey@redhat.com>
To: Michael Eager <eager@eagerm.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix check for ICC incomplete struct types
Date: Wed, 08 Jan 2014 16:38:00 -0000 [thread overview]
Message-ID: <87mwj6cttr.fsf@fleche.redhat.com> (raw)
In-Reply-To: <52CC60B7.60004@eagerm.com> (Michael Eager's message of "Tue, 07 Jan 2014 12:16:55 -0800")
>>>>> "Michael" == Michael Eager <eager@eagerm.com> writes:
Michael> TYPE_IS_OPAQUE does honor TYPE_STUB and checks it before
Michael> TYPE_STUB_SUPPORTED. Which is absolutely screwy, since
Michael> TYPE_STUB_SUPPORTED is set for all non-ICC producers.
Right you are.
I think TYPE_STUB_SUPPORTED is there to handle just the case where
TYPE_STUB is zero. I guess the older symbol readers didn't set
TYPE_STUB, so this hack was introduced. If TYPE_STUB is set, then it's
safe to assume that the symbol reader knew what it was doing.
Michael> I'm happy to remove it and all the associated dreck and
Michael> reorder the test as you suggest.
I think my variant is mildly better because it consolidates all the
TYPE_STUB bits into a single paragraph. If you agree, please go ahead.
Tom
prev parent reply other threads:[~2014-01-08 16:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 17:21 Michael Eager
2014-01-07 18:43 ` Tom Tromey
2014-01-07 20:16 ` Michael Eager
2014-01-08 16:38 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwj6cttr.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=eager@eagerm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).