From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2833 invoked by alias); 8 Jan 2014 16:38:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2821 invoked by uid 89); 8 Jan 2014 16:38:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Jan 2014 16:38:27 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s08GcPUN003174 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 8 Jan 2014 11:38:25 -0500 Received: from barimba (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s08GcOqc004066 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 8 Jan 2014 11:38:24 -0500 From: Tom Tromey To: Michael Eager Cc: "gdb-patches\@sourceware.org" Subject: Re: [PATCH] Fix check for ICC incomplete struct types References: <52CC3790.4030702@eagerm.com> <87bnznhbtn.fsf@fleche.redhat.com> <52CC60B7.60004@eagerm.com> Date: Wed, 08 Jan 2014 16:38:00 -0000 In-Reply-To: <52CC60B7.60004@eagerm.com> (Michael Eager's message of "Tue, 07 Jan 2014 12:16:55 -0800") Message-ID: <87mwj6cttr.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-01/txt/msg00213.txt.bz2 >>>>> "Michael" == Michael Eager writes: Michael> TYPE_IS_OPAQUE does honor TYPE_STUB and checks it before Michael> TYPE_STUB_SUPPORTED. Which is absolutely screwy, since Michael> TYPE_STUB_SUPPORTED is set for all non-ICC producers. Right you are. I think TYPE_STUB_SUPPORTED is there to handle just the case where TYPE_STUB is zero. I guess the older symbol readers didn't set TYPE_STUB, so this hack was introduced. If TYPE_STUB is set, then it's safe to assume that the symbol reader knew what it was doing. Michael> I'm happy to remove it and all the associated dreck and Michael> reorder the test as you suggest. I think my variant is mildly better because it consolidates all the TYPE_STUB bits into a single paragraph. If you agree, please go ahead. Tom