* Fix for bugzilla/16152
@ 2013-11-15 11:39 Steffen Sledz
2013-11-15 15:32 ` Tom Tromey
0 siblings, 1 reply; 8+ messages in thread
From: Steffen Sledz @ 2013-11-15 11:39 UTC (permalink / raw)
To: gdb-patches
Please have a look at <https://sourceware.org/bugzilla/show_bug.cgi?id=16152>.
A patch fixing this problem is attached there.
Thanx,
Steffen Sledz
--
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@dresearch-fe.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Fix for bugzilla/16152
2013-11-15 11:39 Fix for bugzilla/16152 Steffen Sledz
@ 2013-11-15 15:32 ` Tom Tromey
2013-11-15 21:14 ` [PATCH] gdb: fix cygwin check in configure script Steffen Sledz
0 siblings, 1 reply; 8+ messages in thread
From: Tom Tromey @ 2013-11-15 15:32 UTC (permalink / raw)
To: Steffen Sledz; +Cc: gdb-patches
>>>>> "Steffen" == Steffen Sledz <sledz@dresearch-fe.de> writes:
Steffen> Please have a look at
Steffen> <https://sourceware.org/bugzilla/show_bug.cgi?id=16152>. A
Steffen> patch fixing this problem is attached there.
We prefer patches to be submitted to the list, following the
contribution guidelines. Could you do that instead?
Tom
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] gdb: fix cygwin check in configure script
2013-11-15 15:32 ` Tom Tromey
@ 2013-11-15 21:14 ` Steffen Sledz
2013-11-18 15:43 ` Tom Tromey
0 siblings, 1 reply; 8+ messages in thread
From: Steffen Sledz @ 2013-11-15 21:14 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey, Steffen Sledz
Avoids false positives if the search pattern "lose" is found in path
descriptions in comments generated by the preprocessor.
see <https://sourceware.org/bugzilla/show_bug.cgi?id=16152>
Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
---
gdb/configure | 2 +-
gdb/configure.ac | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdb/configure b/gdb/configure
index 8b20a13..0edba09 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -12766,7 +12766,7 @@ lose
#endif
_ACEOF
if (eval "$ac_cpp conftest.$ac_ext") 2>&5 |
- $EGREP "lose" >/dev/null 2>&1; then :
+ $EGREP "^lose$" >/dev/null 2>&1; then :
gdb_cv_os_cygwin=yes
else
gdb_cv_os_cygwin=no
diff --git a/gdb/configure.ac b/gdb/configure.ac
index 88db73a..4d1c419 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -1880,7 +1880,7 @@ AC_SUBST(WERROR_CFLAGS)
# In the Cygwin environment, we need some additional flags.
AC_CACHE_CHECK([for cygwin], gdb_cv_os_cygwin,
-[AC_EGREP_CPP(lose, [
+[AC_EGREP_CPP(^lose$, [
#if defined (__CYGWIN__) || defined (__CYGWIN32__)
lose
#endif],[gdb_cv_os_cygwin=yes],[gdb_cv_os_cygwin=no])])
--
1.8.1.4
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] gdb: fix cygwin check in configure script
2013-11-15 21:14 ` [PATCH] gdb: fix cygwin check in configure script Steffen Sledz
@ 2013-11-18 15:43 ` Tom Tromey
2013-11-24 23:35 ` [PATCH v2] " Steffen Sledz
0 siblings, 1 reply; 8+ messages in thread
From: Tom Tromey @ 2013-11-18 15:43 UTC (permalink / raw)
To: Steffen Sledz; +Cc: gdb-patches
>>>>> "Steffen" == Steffen Sledz <sledz@dresearch-fe.de> writes:
Steffen> Avoids false positives if the search pattern "lose" is found in path
Steffen> descriptions in comments generated by the preprocessor.
Steffen> see <https://sourceware.org/bugzilla/show_bug.cgi?id=16152>
This needs a ChangeLog entry.
Ok with that.
Tom
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2] gdb: fix cygwin check in configure script
2013-11-18 15:43 ` Tom Tromey
@ 2013-11-24 23:35 ` Steffen Sledz
2013-11-27 20:33 ` Pedro Alves
0 siblings, 1 reply; 8+ messages in thread
From: Steffen Sledz @ 2013-11-24 23:35 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey, Steffen Sledz
Avoids false positives if the search pattern "lose" is found in path
descriptions in comments generated by the preprocessor.
see <https://sourceware.org/bugzilla/show_bug.cgi?id=16152>
Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
---
gdb/ChangeLog | 5 +++++
gdb/configure | 2 +-
gdb/configure.ac | 2 +-
3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index aec0768..ead7874 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2013-11-24 Steffen Sledz <sledz@dresearch-fe.de>
+
+ * configure: Rebuild.
+ * configure.ac: fix cygwin detection check
+
2013-11-24 Yao Qi <yao@codesourcery.com>
* disasm.c (dis_asm_read_memory): Call target_read_code
diff --git a/gdb/configure b/gdb/configure
index 5514b2f..b38e183 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -12446,7 +12446,7 @@ lose
#endif
_ACEOF
if (eval "$ac_cpp conftest.$ac_ext") 2>&5 |
- $EGREP "lose" >/dev/null 2>&1; then :
+ $EGREP "^lose$" >/dev/null 2>&1; then :
gdb_cv_os_cygwin=yes
else
gdb_cv_os_cygwin=no
diff --git a/gdb/configure.ac b/gdb/configure.ac
index 9b73887..2947293 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -1877,7 +1877,7 @@ AC_SUBST(WERROR_CFLAGS)
# In the Cygwin environment, we need some additional flags.
AC_CACHE_CHECK([for cygwin], gdb_cv_os_cygwin,
-[AC_EGREP_CPP(lose, [
+[AC_EGREP_CPP(^lose$, [
#if defined (__CYGWIN__) || defined (__CYGWIN32__)
lose
#endif],[gdb_cv_os_cygwin=yes],[gdb_cv_os_cygwin=no])])
--
1.8.4
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] gdb: fix cygwin check in configure script
2013-11-24 23:35 ` [PATCH v2] " Steffen Sledz
@ 2013-11-27 20:33 ` Pedro Alves
2013-11-27 21:47 ` Steffen Sledz
0 siblings, 1 reply; 8+ messages in thread
From: Pedro Alves @ 2013-11-27 20:33 UTC (permalink / raw)
To: Steffen Sledz; +Cc: gdb-patches, Tom Tromey
Pushed, thanks.
--
Pedro Alves
On 11/24/2013 12:13 PM, Steffen Sledz wrote:
> Avoids false positives if the search pattern "lose" is found in path
> descriptions in comments generated by the preprocessor.
>
> see <https://sourceware.org/bugzilla/show_bug.cgi?id=16152>
>
> Signed-off-by: Steffen Sledz <sledz@dresearch-fe.de>
> ---
> gdb/ChangeLog | 5 +++++
> gdb/configure | 2 +-
> gdb/configure.ac | 2 +-
> 3 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index aec0768..ead7874 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,3 +1,8 @@
> +2013-11-24 Steffen Sledz <sledz@dresearch-fe.de>
> +
> + * configure: Rebuild.
> + * configure.ac: fix cygwin detection check
> +
> 2013-11-24 Yao Qi <yao@codesourcery.com>
>
> * disasm.c (dis_asm_read_memory): Call target_read_code
> diff --git a/gdb/configure b/gdb/configure
> index 5514b2f..b38e183 100755
> --- a/gdb/configure
> +++ b/gdb/configure
> @@ -12446,7 +12446,7 @@ lose
> #endif
> _ACEOF
> if (eval "$ac_cpp conftest.$ac_ext") 2>&5 |
> - $EGREP "lose" >/dev/null 2>&1; then :
> + $EGREP "^lose$" >/dev/null 2>&1; then :
> gdb_cv_os_cygwin=yes
> else
> gdb_cv_os_cygwin=no
> diff --git a/gdb/configure.ac b/gdb/configure.ac
> index 9b73887..2947293 100644
> --- a/gdb/configure.ac
> +++ b/gdb/configure.ac
> @@ -1877,7 +1877,7 @@ AC_SUBST(WERROR_CFLAGS)
>
> # In the Cygwin environment, we need some additional flags.
> AC_CACHE_CHECK([for cygwin], gdb_cv_os_cygwin,
> -[AC_EGREP_CPP(lose, [
> +[AC_EGREP_CPP(^lose$, [
> #if defined (__CYGWIN__) || defined (__CYGWIN32__)
> lose
> #endif],[gdb_cv_os_cygwin=yes],[gdb_cv_os_cygwin=no])])
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] gdb: fix cygwin check in configure script
2013-11-27 20:33 ` Pedro Alves
@ 2013-11-27 21:47 ` Steffen Sledz
2013-11-27 22:04 ` Tom Tromey
0 siblings, 1 reply; 8+ messages in thread
From: Steffen Sledz @ 2013-11-27 21:47 UTC (permalink / raw)
To: Pedro Alves; +Cc: gdb-patches, Tom Tromey
Am 27.11.2013 19:53, schrieb Pedro Alves:
> Pushed, thanks.
Great!
So someone should close the related issue[1] in the bugtracker!
Steffen
[1] <https://sourceware.org/bugzilla/show_bug.cgi?id=16152>
--
DResearch Fahrzeugelektronik GmbH
Otto-Schmirgal-Str. 3, 10319 Berlin, Germany
Tel: +49 30 515932-237 mailto:sledz@dresearch-fe.de
Fax: +49 30 515932-299
Geschäftsführer: Dr. Michael Weber, Werner Mögle;
Amtsgericht Berlin Charlottenburg; HRB 130120 B;
Ust.-IDNr. DE273952058
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] gdb: fix cygwin check in configure script
2013-11-27 21:47 ` Steffen Sledz
@ 2013-11-27 22:04 ` Tom Tromey
0 siblings, 0 replies; 8+ messages in thread
From: Tom Tromey @ 2013-11-27 22:04 UTC (permalink / raw)
To: Steffen Sledz; +Cc: Pedro Alves, gdb-patches
>>>>> "Steffen" == Steffen Sledz <sledz@dresearch-fe.de> writes:
Steffen> So someone should close the related issue[1] in the bugtracker!
Steffen> [1] <https://sourceware.org/bugzilla/show_bug.cgi?id=16152>
I closed it.
FWIW it's best if you mention relevant PRs when sending the patch.
Tom
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-11-27 21:33 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-11-15 11:39 Fix for bugzilla/16152 Steffen Sledz
2013-11-15 15:32 ` Tom Tromey
2013-11-15 21:14 ` [PATCH] gdb: fix cygwin check in configure script Steffen Sledz
2013-11-18 15:43 ` Tom Tromey
2013-11-24 23:35 ` [PATCH v2] " Steffen Sledz
2013-11-27 20:33 ` Pedro Alves
2013-11-27 21:47 ` Steffen Sledz
2013-11-27 22:04 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).