From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) by sourceware.org (Postfix) with ESMTPS id C526A385828B for ; Mon, 10 Jun 2024 20:27:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C526A385828B Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C526A385828B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::136 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718051228; cv=none; b=Y871PzLM7oJAsT1eJ2de2f7GllmhdzIZFnse+d75o+v4aX7CahRKPqwRitvb9e+YJzIa2patlHj4zEORAf1xLjqvLi478wHD8qKt6YyeAk1VTf86OBeqH0z9M3QgadxcZoRNyKSAiRk30rYXdw2iy22nY5aEBpyCuyVONk2COYI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718051228; c=relaxed/simple; bh=lHzmwo0q5kOPdEukncvtLIWW+wcfpLCEBuehmwTZcWM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=CLXTnS/C3CEk2W83fjgJCDu0PRpkY/Sd7rpn/o+CMlAXy7+MB0noP2b0riiXPwCN7pnL6dZZlE1b3WeTJncRhYQLbnqSUT/PQc7a5e3xRofeE/yoJ8CnRm2OUr4iglRQMJiUQQBgNeI5SYma0GouYt6bceb2DRrhLjfJtLroBqM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x136.google.com with SMTP id e9e14a558f8ab-37588517095so14644445ab.2 for ; Mon, 10 Jun 2024 13:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1718051224; x=1718656024; darn=sourceware.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=919LZnYFSAb8hUbSC902d+WUdvzJgspIoBu9EBob+4s=; b=bbwtjLJ+8FFL//kjoWTxJom4HB0UzrBtFgMiL7DR+id/9z8rXJzp2MSjvtzHLE9G9V SQ96Htt7ClBdQ5NA7CXUidEXyKBatF/5ImvEU8igvbAnOMchtb0weSxnzgYuOj6TgHeV QBSOAR2YCduTLybvuW0UVf2wkGnuCYpEUngW6k1ISz1upeyhotLTknjO5m4krjMVbENC 4TVKjeVwJL48EjJhT5zi+l1IqZlmUvUZPS5LkXLPb8wUdXWgEAdVWdKBhlpYyRAlG+4X nIRjJiPZM92nJrc1ZA9wFNFVqyc3xPz6Yz13xL9FKOqY0EvWfBmBnhYzNdLXd7SL1/Vf viig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718051224; x=1718656024; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=919LZnYFSAb8hUbSC902d+WUdvzJgspIoBu9EBob+4s=; b=P6bLvIFqAHAfQw4E3JxYF54nxMJcoo2YifcOl6WUZnxXzke4tKe1qVUs0bFGo3tajO T/BXAoeJu+LKv6cuj+omEE92gfDSJketfArODS4kWobmQwE4h8B+AQSXMMZtC2QknH39 I9sXfbxdl60wbBZaA4XNkHt1bepNIg8foDTs9RfICXWYHvnZgVoxH7yMyXW5IoTLPrx1 nF8pVBV9FP7ZsTw1rrAg8nhKGy4Y9WhO2tFyUeM6NOD0fCbUogaLeOfc+zzmcytoUcyw O29K5OcK3pTe9Fi0aj1NIiGVyDpttud3ZUzNiyP8FVgpt4KWBlPfhdlHZ/BUDPtkI1Ow PgRg== X-Gm-Message-State: AOJu0Yw+zMN8Mv9tbdKRd8VgrQDDbQlFbpC2rhZSLtSXUgg0jrHICrVs DQ7a0+L1DZ0LMkZElV3LoncKZx7kTQ+JifGTWYpL59wah1OFIFB6TvD3c6WGeg== X-Google-Smtp-Source: AGHT+IGxxoFXXvpPSmi47kWsCHRUlCNqckjxL3MLKnnJjdQG3+rZMdatNjs0TNRWehIaP6rN+jm0Dg== X-Received: by 2002:a05:6e02:12e9:b0:375:b4a3:9bc4 with SMTP id e9e14a558f8ab-375b4a3a1a2mr3597895ab.28.1718051224570; Mon, 10 Jun 2024 13:27:04 -0700 (PDT) Received: from murgatroyd (75-166-134-4.hlrn.qwest.net. [75.166.134.4]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-37592d3b331sm15950795ab.31.2024.06.10.13.27.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 13:27:04 -0700 (PDT) From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Make global_symbol_searcher::filenames private In-Reply-To: <20240524183338.1996024-1-tromey@adacore.com> (Tom Tromey's message of "Fri, 24 May 2024 12:33:38 -0600") References: <20240524183338.1996024-1-tromey@adacore.com> X-Attribution: Tom Date: Mon, 10 Jun 2024 14:27:03 -0600 Message-ID: <87o788ilwo.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey writes: Tom> This patch renames global_symbol_searcher::filenames and makes it Tom> private, adding a new method to append a filename to the vector. This Tom> also cleans up memory management here, removing an alloca from rbreak, Tom> and removing a somewhat ugly SCOPE_EXIT from the Python code, in favor Tom> of having global_symbol_searcher manage the memory itself. I'm checking this in now. Tom