From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 134173858C42 for ; Tue, 23 Apr 2024 14:39:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 134173858C42 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 134173858C42 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713883178; cv=none; b=YV0VrWaig6hO7dQso+7TNmD8JtbKNLyt37bwAa5MDHuQYl6XMUujeENAea5tfmOYidj0+POWIBPdHnyTIoTj9oq1Lbt6+lXa7juwGs5jDcZ+hQdsn3UPavFqkax3EW/xZN2izkWtWP7OuIErz80jrgykv/18KqUB0y5bJmw2AEU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713883178; c=relaxed/simple; bh=uthASBbWIPY2CB30I8Q2FlkTi7l0DfRS9nJH7diXPLo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=VFUkB9jkcg9HCKb2KYOV/yiDXDitOztH8Z4+Y7K2WlND6H/ckKkUUnwIoiOs6X/DmC0xeGhZdh0MTXwXsj3WBUDPwolg3iL/b6yznIGiMNrL88jDFer2cXBEmZcI+jFBd/gw8lst4ruAuJr5q9KTJiZ4MdP566LI8TvFbjBZZJM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6009a.ext.cloudfilter.net ([10.0.30.184]) by cmsmtp with ESMTPS id z8fmrLU7bQr4SzHJ0r8Do8; Tue, 23 Apr 2024 14:39:34 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id zHIzr8ADenNCOzHJ0rVnP7; Tue, 23 Apr 2024 14:39:34 +0000 X-Authority-Analysis: v=2.4 cv=DKCJ4TNb c=1 sm=1 tr=0 ts=6627c826 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=raytVjVEu-sA:10 a=Qbun_eYptAEA:10 a=7d_E57ReAAAA:8 a=zstS-IiYAAAA:8 a=3FS69I0h6INvy83OgSkA:9 a=0inONp2fGgEA:10 a=jhqOcbufqs7Y1TYCrUUU:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Z+rt5zwt+xeSzTs4ex+rucH1/HjJU71+DvCy9sgWZs4=; b=Xu4eN6RgqaehsIJDU59+uGMzuV 1Z6VUw29KoBnHgD5ZTpkEAMqZkc3l96SLYBWokizxPF6sX9YoljMNavzONED40xI8Hv4Yv1pI0Lco 8X55G0WsrLpOjMVDUQLhc9YxG; Received: from 97-122-86-252.hlrn.qwest.net ([97.122.86.252]:42886 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rzHIz-0021PP-1o; Tue, 23 Apr 2024 08:39:33 -0600 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/dwarf2/read.c: remove pessimizing std::move References: <20240422190139.36506-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Tue, 23 Apr 2024 08:39:32 -0600 In-Reply-To: <20240422190139.36506-1-simon.marchi@efficios.com> (Simon Marchi's message of "Mon, 22 Apr 2024 15:01:37 -0400") Message-ID: <87o7a0qh23.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.86.252 X-Source-L: No X-Exim-ID: 1rzHIz-0021PP-1o X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-86-252.hlrn.qwest.net (murgatroyd) [97.122.86.252]:42886 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfCQtBqXAhwzbRkMchlBxQTsqjjTpL/qptuCHGR2WfE6lmC+Ct1CSBBYkh4l7Oyiqi7GZKjKlKAGhUoAVRvLLCdmGtt9iEx3OYDsaxBrd+MmrAMaUVO8U Zcvh18H8zhDpLb+dB43VUXH6KnyjpIPyQ8U/zr1Umw0cy398vAhKvko2PXFdwfuuOe6gN7WbSN2IRME8uVAzs9JY75V+gqoEvlk= X-Spam-Status: No, score=-3015.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi writes: Simon> The compiler seems right, there is not need to std::move the result of Simon> `release_parent_map ()`, it's already going to be an rvalue. Remove the Simon> std::move. Thanks. Approved-By: Tom Tromey Tom