From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdbsupport: constify some return values in print-utils.{h, cc}
Date: Thu, 18 Apr 2024 08:10:12 -0600 [thread overview]
Message-ID: <87o7a6zrqz.fsf@tromey.com> (raw)
In-Reply-To: <20240417205530.2033347-1-simon.marchi@polymtl.ca> (Simon Marchi's message of "Wed, 17 Apr 2024 16:55:28 -0400")
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> There is no reason the callers of these functions need to change the
Simon> returned string, so change the `char *` return types to `const char *`.
Simon> Update a few callers to also use `const char *`.
Seems reasonable to me.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2024-04-18 14:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 20:55 [PATCH] gdbsupport: constify some return values in print-utils.{h,cc} Simon Marchi
2024-04-18 14:10 ` Tom Tromey [this message]
2024-04-18 14:32 ` [PATCH] gdbsupport: constify some return values in print-utils.{h, cc} Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7a6zrqz.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).