From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id B66CA38582A1 for ; Wed, 14 Feb 2024 15:46:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B66CA38582A1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B66CA38582A1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707925567; cv=none; b=Sv4Eyrrr5WPWE/EC8FbrNpzkoW3YFvR0R/GIUU2luCXdlkMvNML+ncg9bpaDecdv7TrzIUfjcbqj7SNuZKw87OvshHV5SkHDDo6L1Rp9w30BFMDfTJIAAxg5AP+3mxpPOPDkwXPkZppu8qxhElLdffe9E0vyAURPSi5FLRIwZrA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707925567; c=relaxed/simple; bh=ICpv+LqiwCtLdLCfwMDH848BaCaGtlDcHMFId0x+Qv4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=gI+nRkNnIr95Ase7zBJeETzy9P25Swn1izzc4+PQ0TyTyhx1mOAV15IvJVcvWaoqXfdYtE+9pXfaIskXPLXX3yIEvKxS58EGK+3kTyeDXhDEsbzylZpI2K1ZJCIWng1+w5IDVIhqP7/KtHygDuxj7+m2JXgzMsy1LMlOgJTv2F4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6002a.ext.cloudfilter.net ([10.0.30.222]) by cmsmtp with ESMTPS id aFAhrJmzLpUFLaHSWrGrVS; Wed, 14 Feb 2024 15:46:04 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id aHSVrmQI94k1baHSVrS5HW; Wed, 14 Feb 2024 15:46:04 +0000 X-Authority-Analysis: v=2.4 cv=Xdoqz555 c=1 sm=1 tr=0 ts=65cce03c a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=k7vzHIieQBIA:10 a=Qbun_eYptAEA:10 a=zstS-IiYAAAA:8 a=knAm6082PfATVqfQXz8A:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ICpv+LqiwCtLdLCfwMDH848BaCaGtlDcHMFId0x+Qv4=; b=tkjhcI2iie+/CfnZ6exSVfZflp JvPNTh5/pHHaOAbBO0lY2fhlG9lwWpoxPS6FoiPq1iR/B7yhzZnXaLx7OwQ+1H6/cpkK6yJnetWOP 70QF3DG++nQ95+ZnBap4QL+s5; Received: from 71-211-170-195.hlrn.qwest.net ([71.211.170.195]:51926 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1raHSV-004Lmz-0p; Wed, 14 Feb 2024 08:46:03 -0700 From: Tom Tromey To: Tom de Vries Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb/dap] Fix exit race References: <20240213150141.28034-1-tdevries@suse.de> <87a5o45j77.fsf@tromey.com> X-Attribution: Tom Date: Wed, 14 Feb 2024 08:46:02 -0700 In-Reply-To: (Tom de Vries's message of "Wed, 14 Feb 2024 16:39:43 +0100") Message-ID: <87o7cj3v7p.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.170.195 X-Source-L: No X-Exim-ID: 1raHSV-004Lmz-0p X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-170-195.hlrn.qwest.net (murgatroyd) [71.211.170.195]:51926 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfEJSMm/YDocCUuWC/P2PXC2fopd6CrJnaZW45Sg0i5htRExjVHNBttIrNdGD//HRZagI2wai3jhm3OzSHwGe8zCIVgX22ucopWoWNTN5woAnjuv15uSD GTalMHNpWWjhb1C+kziSistk1ZbIufrE6jklQqj9shnP4QOS0eSy2DsuZZ8QoNBOoOdLcTpscyptIVAhnNv2swhVNRqUAW+4D4k= X-Spam-Status: No, score=-3015.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_VALIDITY_RPBL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries writes: Tom> On 2/13/24 19:10, Tom Tromey wrote: >>>>>>> "Tom" == Tom de Vries writes: Tom> Fix this by removing the send_gdb("quit"). >> I thought you were sending a different patch for this? Tom> This is the patch for PR31306, the assertion failure. >> I think this change by itself is insufficient because it might mean that >> gdb exits before all the queued responses are emitted. Tom> As for PR31380, which is about ensuring responses are flushed to Tom> client before exiting, indeed there's a race between flushing the Tom> write queue and gdb exiting because of a SIGHUP (which is not caused Tom> by the send_gdb("quit"), I've mentioned that in the PR. Alright, it's fine by me if you want to do them separately as well. Approved-By: Tom Tromey Tom