From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id CE0B73858C78 for ; Fri, 19 Jan 2024 17:06:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CE0B73858C78 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CE0B73858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705684002; cv=none; b=xLPDrzDFRUy8wwrvE3HYhdPFLQ73aU3RBwlHDP6KCQivlZ9pT3UTBW0VDF9ycMoRMshez4J4HUasqDV1B6sELa2SP7KabA8F2RgoYal6vr+Ppps8waTo7h2L6d7CXNlMfUkgDpZDkqB3mSTxNlfCq4u95eY+WjcEAtQNMnSw/jM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705684002; c=relaxed/simple; bh=7CkutMl6n2215iPI5+gn7Iysks954rvMdfz1v3Ormts=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=rqezov+frwtBfN5JffZQULghGkvdeO2NbtPA4kkHN5ZL9ISlRsdxGJrrrVWaYMEIx2+ICkG+PJzQKDvOkbqHMqM3IWBhxMh7nAZCv9IZVw8Fa00YMWjM4hujabpUwmUV0tdm4nNoiGcemfx9IxPRetuSP2zlAqgGEZ8vR7yyscA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6008a.ext.cloudfilter.net ([10.0.30.227]) by cmsmtp with ESMTPS id QpPirf12Q80oiQsKGr8ZUm; Fri, 19 Jan 2024 17:06:40 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id QsKFrYs1nZKctQsKFrU0sV; Fri, 19 Jan 2024 17:06:39 +0000 X-Authority-Analysis: v=2.4 cv=a+kjSGeF c=1 sm=1 tr=0 ts=65aaac1f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=dEuoMetlWLkA:10 a=Qbun_eYptAEA:10 a=7d_E57ReAAAA:8 a=6khhNxy_C5BhN6xwMYUA:9 a=jhqOcbufqs7Y1TYCrUUU:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2ZlBDNT3kg3Nubi4oQ/zQsk9RQotmeloh+R81WJoAQ0=; b=O/q3Dppzp5cEFdmuSjf1QA/ifi 58W0RI1wWqCK/1MnDa24CSEtZZyNpNzkZtWrsjK2jTBKHXcY6afYz8QZ9EMTrc2rWsFJjTwv1xUuA pbE+aDHtCje5+5UqzSk2fkE6r; Received: from 97-122-68-157.hlrn.qwest.net ([97.122.68.157]:58634 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rQsKF-001ZIn-02; Fri, 19 Jan 2024 10:06:39 -0700 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: remove SYMBOL_*_OPS macros References: <20240119163148.70597-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Fri, 19 Jan 2024 10:06:36 -0700 In-Reply-To: <20240119163148.70597-1-simon.marchi@efficios.com> (Simon Marchi's message of "Fri, 19 Jan 2024 11:31:47 -0500") Message-ID: <87o7dhl0bn.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.157 X-Source-L: No X-Exim-ID: 1rQsKF-001ZIn-02 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-157.hlrn.qwest.net (murgatroyd) [97.122.68.157]:58634 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNcSN/rgfM70/nlV+dofUgHGGQyun0GIg+22Y7nAcyuFZFJ6oQz0Lr3SJ2GGM4HjFxCDWGM8l9xklLewqPvTmlwDNYQouL0nDkyeFqpV4QnGW4H+1+/w VwfVSRr102b15F7z923kgVavbLEagYt2xTZfj344mLjMpiL8n//JVsqHAlQv9R5KX9ePN+Z/Wy1J1C7Ncam8UBfH2YQ6H8ySnH8= X-Spam-Status: No, score=-3016.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,KAM_STOCKGEN,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi writes: Simon> Remove SYMBOL_BLOCK_OPS, SYMBOL_COMPUTED_OPS and SYMBOL_REGISTER_OPS, in Simon> favor of methods on struct symbol. More changes could be done here to Simon> improve the design and make things safer, but I just wanted to do a Simon> straightforward change to remove the macros for now. Thanks. Simon> + if (auto computed_ops = var->computed_ops ()) Simon> + return computed_ops->read_variable (var, frame); This one spot uses auto, but no other change does. That seemed weird. Normally I wouldn't mention it but I also noticed: Simon> + if (framefunc != nullptr) Simon> + { Looks like the wrong indentation here. Tom