From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id 2180A385C6DF for ; Wed, 13 Dec 2023 16:36:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2180A385C6DF Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2180A385C6DF Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702485367; cv=none; b=v+bBVASp0IEC04rz3tM3EXjcU9YfytDWBC7b6UEsI5tl0WmIoUrA4vUYq/hnT2ajiMsDxa/eK2SfnkKFoavsAJO2As02U0qJFU3BeBva0QyIyjlV3rcjbWOutOafxWk0Ufs6I7fXl/3CJuWM7CWH4z2iJhqO4bMyvGoBjzJpCJs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702485367; c=relaxed/simple; bh=5Lg4KEGGh2/iS1bvAhEtTFtDlCTxCZvDRbq475my00U=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Ek/ugzHP5SXRJzxHWx2iJExyfy1tB+HrtF+41nBfBY5kOfS0wIJTxaJLPxqCnwbMcCAFHG6pDVTTEimbDFTeoBZWpLZl0Y8hFyIJE1piIUI4pKWyyQyvJdWZMwzPsLl10+KPZOdUofMrJ16KqK5lv8HhXGUc6wav4vG0D0/rE/o= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-54f4b31494fso11290720a12.1 for ; Wed, 13 Dec 2023 08:36:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1702485362; x=1703090162; darn=sourceware.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Dy62JTvPoZGd0Wj+k4Id6FJ73PqJiwsy758vY0O8DUk=; b=HZ1idnzf/4mVWXpeNKbE/gZMe37tlxMAWYReHR1hKPHO8YxIGqf80rQAGr7tW4bXGe RY8Jx961tnE4ToJCeG5sGsf+/G9Rw0vrX+VTRqfJey4ahOl1Ihxnqv+CuuApEG+hYXpc PT3bM/VR2TUkMj+bjx4TYCTrLx5212JXSapFNGBqtvbIkLQnSNrXqmFxYb8JnEhsbyp8 dsK1tI7+BOqbdyQ5b5ElziRDEkRpzYHwoltz+kbx1tRqkbjH2EbFarAjYUHPeRXUmgRv h75I+AJt0PPsGHynnqNrWJvY11dvqHvqnDlxRSeJhlM3gwwG7V0pDIX96Fu5XPoyCBYm 1aBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702485362; x=1703090162; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Dy62JTvPoZGd0Wj+k4Id6FJ73PqJiwsy758vY0O8DUk=; b=Mw/v0UXvxyL9x4B4gQNM+YJ1NKCQp7UEHydJ6qqdhIqopklmDXQp5fVCx3cnx/Sh+x wYxTggVZ4maN947mGZ7IljMv8a0MjIKmI2l0rby25t4v/guf1kuSaLpBLldU+ajfJkDg BhRwsBpU8yz9D8Jlt3zn4equhkod1xkEqsM6vW2l7AriOvBs/9XE6K/pwQj/idqZahqs tsH8qPcm/85Lw0+GhSSPflj0Cxth5mfAQHvqpabWbKOkentg4ysdSMOR51Vq+PbwcSmz TeG9Wjva/jII95tUvjEmeSNTFT8nMwfuKAEllO6rApMRDJz7mae+Yq0ZSo7vd/2FB0vp 6TDQ== X-Gm-Message-State: AOJu0Yz4ii/A0ke2opFMFhcMRB2ZrEuVWt4nihNYqL4ai4+J8KaeXgc9 WMHkEtz/8t8OSiTVGH/WrsznEtFJ8K/2TjGnH01ycA== X-Google-Smtp-Source: AGHT+IEb4IzVfQwf2gFuybR+pm78NLlgRs4EC4zklTJF2PUNtMnpX6hR+i6Wu/B08w6x33fyf/VQnA== X-Received: by 2002:a50:baea:0:b0:54c:bb9c:4b88 with SMTP id x97-20020a50baea000000b0054cbb9c4b88mr8236546ede.5.1702485362522; Wed, 13 Dec 2023 08:36:02 -0800 (PST) Received: from legouguec-Precision-7550 ([2.57.72.67]) by smtp.gmail.com with ESMTPSA id cq27-20020a056402221b00b00551e7858f79sm1052606edb.15.2023.12.13.08.36.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 08:36:02 -0800 (PST) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 3/4] Avoid exception from attach in DAP In-Reply-To: <20231212-dap-no-test-exceptions-v1-3-af0e33f10093@adacore.com> (Tom Tromey's message of "Tue, 12 Dec 2023 10:44:44 -0700") References: <20231212-dap-no-test-exceptions-v1-0-af0e33f10093@adacore.com> <20231212-dap-no-test-exceptions-v1-3-af0e33f10093@adacore.com> Date: Wed, 13 Dec 2023 17:36:01 +0100 Message-ID: <87o7eu3vri.fsf@adacore.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: > + if "reason" not in event.details: > + # This can only really happen via a "repl" evaluation of > + # something like "attach". In this case just emit a generic > + # stop. > + obj["reason"] =3D "stopped" > else: > - obj["reason"] =3D stop_reason_map[reason] > + reason =3D event.details["reason"] > + if ( > + _expected_pause > + and reason =3D=3D "signal-received" > + and event.details["signal-name"] in ("SIGINT", "SIGSTOP") > + ): > + obj["reason"] =3D "pause" > + else: > + global stop_reason_map > + obj["reason"] =3D stop_reason_map[reason] > _expected_pause =3D False > send_event("stopped", obj) Nit: I'd find if "reason" not in event.details: # ... obj["reason"] =3D "stopped" elif ( _expected_pause and event.details["reason"] =3D=3D "signal-received" and event.details["signal-name"] in ("SIGINT", "SIGSTOP") ): obj["reason"] =3D "pause" else: global stop_reason_map obj["reason"] =3D stop_reason_map[event.details["reason"]] slightly more legible (less nesting; easier to understand that the purpose of each branch is to set obj["reason"]), even if it means repeating event.details["reason"]. Really not a huge deal though, good to go as-is for me. Reviewed-By: K=C3=A9vin Le Gouguec