From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 30CF03858C54 for ; Tue, 28 Nov 2023 18:30:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 30CF03858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 30CF03858C54 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701196248; cv=none; b=hen2mD2KvXhqynwA9rDTMwG2EajX2qb53hb/gxFiObfOZBmcMPuhpn21zNS7b14vS+RXR63ujNCL5Ve0CsCbnnXMdajGgDiPwPHPoYF33BFFoKlybZj5rcyg4iOmDdkc1gOr0/42dq4H9p24XOAMbx8sr8IMc0DZBp1G4Mywk5w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701196248; c=relaxed/simple; bh=7kWPeLzASvS9oi2TRWxqnPTac9EzhR5YiO5Tkh6/dtY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=FjuW1n8IyCpJLtNx4mSAr9pEb4nRW7W1nyU9coNC2JCFPOhQcEAEuUwAtGZYRUiAoklF3q+Boj77oDkdpAzYH9P0V6x0n2tEp9bTeFcrk46gXdpRuO5uQ6yW43w7FX3FF9cFWBgUel7pFgAwOK5QUN8eFNgpYotsu8P3Sdgi6nI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701196246; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8tIrTLSQ1HN4sc5Ao+oXfveIbeE4pwtgUOqBn0U73TU=; b=DvJerx/1tstUHiyznGPdpkLPHBZ4bmNu0MjCElFP18mCUwwZY0BOEDfR9kTetp4S6Oy81B A0ylV33lgrDN8bC27ooRw28JkPk9ZqJBHJMl8JF71np5rpnOkC9+YYup6uhP56NgVnbd8F LxEOmNHMwN6pL5rgR386MXPeBOzZH9w= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-54-Ib6SuNfWOmu__zsWZm1-Yw-1; Tue, 28 Nov 2023 13:30:39 -0500 X-MC-Unique: Ib6SuNfWOmu__zsWZm1-Yw-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-333120f8976so444674f8f.3 for ; Tue, 28 Nov 2023 10:30:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701196238; x=1701801038; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8tIrTLSQ1HN4sc5Ao+oXfveIbeE4pwtgUOqBn0U73TU=; b=jGKU26wj3BMg+aqhcSCD7zypthwTUWxbde7uldwQ0Q6bQaXuZMTz+vE6rpCApCgAUk NtMBFteDEkbqZjVROLraxJUzdvCpkn+jNRGPXAKQusyNiJTUuIiAlvxKfBLw/DXHC+y6 YCFsmMW3TRHQG1btwySbJuCudpxic1VpkkJMa7xUEkyZoVdPUAw0yS9GyXC/gnTKWT5I ZmBr9gqy/lb5kuT4Cxf6ZnEuPMmup1lj6UBfFWfXTMmH41xU0IGPDNQYM12Xi7Fei/qo l2HC1eYjbyYKy/ABUW0qqPt9NMdWWAO9JVqCuMc+8fLYKTewKrUUXbv6IQva5dp7AODn tGAw== X-Gm-Message-State: AOJu0YxDHtweOqlrKFtPI/l254LM2IRTAv/XED52tDrgO+fA/dF5WFwc ao4Yp2p2kOwuCE5DzeYYEcXG2318IcJWQSJ8WMQ9uL0+1FTKUotxvKajIbnFc6y0lQumhKYeLCW vrde6R74QPjMS3HMcyt+PtWE+z4B4oQ== X-Received: by 2002:a05:6000:1544:b0:333:179:d8e3 with SMTP id 4-20020a056000154400b003330179d8e3mr4914301wry.34.1701196238024; Tue, 28 Nov 2023 10:30:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IG6ntzt7Jaqw16nIjHdyxSZbWJCADobns2Kt0WDnS1NFw3PPMYRh5ZYxEZphtyst6FJQUDEwQ== X-Received: by 2002:a05:6000:1544:b0:333:179:d8e3 with SMTP id 4-20020a056000154400b003330179d8e3mr4914287wry.34.1701196237682; Tue, 28 Nov 2023 10:30:37 -0800 (PST) Received: from localhost (105.226.159.143.dyn.plus.net. [143.159.226.105]) by smtp.gmail.com with ESMTPSA id v6-20020a5d4a46000000b003330b55b941sm2779649wrs.77.2023.11.28.10.30.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 10:30:37 -0800 (PST) From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/python: display errors from command completion In-Reply-To: <8734wpewaw.fsf@tromey.com> References: <66d012a42add48d890d0504b95c9f3a6daa37042.1701169440.git.aburgess@redhat.com> <8734wpewaw.fsf@tromey.com> Date: Tue, 28 Nov 2023 18:30:36 +0000 Message-ID: <87o7fdohmb.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> This commit makes the gdb.Command.complete methods more verbose when > Andrew> it comes to error handling. > > Thank you for doing this. > > Andrew> + gdbpy_print_stack_or_quit (); > > Hah, I didn't know about this one. > Some overlap with gdbpy_handle_exception here. > > Anyway, this looks good to me. > Approved-By: Tom Tromey Pushed. Thanks, Andrew