From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by sourceware.org (Postfix) with ESMTPS id 06C0B38582AC for ; Mon, 27 Nov 2023 15:54:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 06C0B38582AC Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 06C0B38582AC Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d30 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701100482; cv=none; b=SghfZJj7yUV3XBJg6/t7SXkeKHOEj2J7TuW14E1+sU9473MPyp8N3v0KEO9c0x0i4Rk2g94HlqfBNrDYwpWL4Saw4HTUnMzJMRXT5ISFxsRI/V6UoLgfvRH/kAA7bJ9H/Gly1xeNlFNKCnbkLKvDFJwiUzezzDhsKy2y0hQxNnw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701100482; c=relaxed/simple; bh=cdwKt5m4RMtKene3VU/oghF31JOchMK17ioTZDhx8ZQ=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Ths+VTGtXN+9TA9NM4qFc8jjeb4Rpx7t0lEsWhI4mY6VjlJNRExsn++lQTRvOReabW18E44rzTdgxvgw5VHXL3YLArpcnJbRmA8fPDI7zPFJPInxd1Epqe/4uBTKk27dt5ELUmcYjH0s7j1Le1DB8r15JgIYB2hkO3X8zhZgeVk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd30.google.com with SMTP id ca18e2360f4ac-7b06841efdcso162478839f.2 for ; Mon, 27 Nov 2023 07:54:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1701100479; x=1701705279; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=XLmfDWGeCQ4kfOPksqnEutGjSqdcCQMVqkQcvmyDJLo=; b=iG7l2r8IuMJpJJcdq8FmmE5/rry+nAjiq3vPEhl+9+UcZPS3uMDQ7t6akpYxmpCFck U2DFBKsU4er0kBOgnQefGeaEx3Q4C9KU/k3veC8FZUMvZmWY2F59xJk/It1xV2rzJKMe kH9q8RDgfxMHt+kao7WFQkUhVo6s+cG6cUhBGAujSjMTeQ8j4kAZRVT4Ip2ipE+CKFBv JsEIetpIhaLH1+sRPtuyvjLm3MPAtgUs/N1GqnO9t3/Gw8yRJ5m1ecrGB7YHMfacdfsf PDOAcn530gKk/rPUqsW3dA2qu802XYfmPWSsJsk0pVbw0OjkEqBH4AcSseRJBUjesSzo bc+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701100479; x=1701705279; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XLmfDWGeCQ4kfOPksqnEutGjSqdcCQMVqkQcvmyDJLo=; b=qopl7ewiQbVjWBc/GtPYRBVCz3HgqV4ZXiziAwJaaZEyAAiQnCcQqRGXIGGkXKmb89 MGJUdPQgs1ngbxb693a6NkRMmmb65KPg8lpzb2q3vvaY1BWA8Aq26AqJhrEZ/jTl8M/8 0etJd5iUBAQ1gqUGMgY+6I9/IFUc7Tb296mXq+uxpBODUSsS4fJ8BU6wYiNIDJ4wTOly 6OSendPcl+9YLFjGV0IyDVo2lxcp70c+SwK82LhcftsstOeNyw7KJ9lS1WYWJfDPV48c fZI06H4K3wgysyMXYvwXNm8k3qas3sloRBNI9l+HdF3hmknVBRWXfM9N/G1JQt6WVhJo MREw== X-Gm-Message-State: AOJu0Yw+B18H9DNuLtqsWsDZf6Rv38S03sJoLYoLAFf0RBK5m2p4hQmq ua0YTTTSFH1hdWmRmb6SncuqiA== X-Google-Smtp-Source: AGHT+IGXLnZpnUNFMHbCUTk88tsyrrcuH8OYvZSi3eL7YS0PMn2lpOKKEvEHM2TVQLGb+pHP/GKMew== X-Received: by 2002:a6b:fc03:0:b0:7b3:4ee5:7a78 with SMTP id r3-20020a6bfc03000000b007b34ee57a78mr8238225ioh.18.1701100479265; Mon, 27 Nov 2023 07:54:39 -0800 (PST) Received: from murgatroyd (97-122-77-73.hlrn.qwest.net. [97.122.77.73]) by smtp.gmail.com with ESMTPSA id j5-20020a6b3105000000b007a6773bd8dfsm2509949ioa.16.2023.11.27.07.54.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 07:54:38 -0800 (PST) From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix bug in DAP handling of 'pause' requests References: <20231117174901.4111817-1-tromey@adacore.com> X-Attribution: Tom Date: Mon, 27 Nov 2023 08:54:38 -0700 In-Reply-To: <20231117174901.4111817-1-tromey@adacore.com> (Tom Tromey's message of "Fri, 17 Nov 2023 10:49:01 -0700") Message-ID: <87o7fffayp.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey writes: Tom> While working on cancellation, I noticed that a DAP 'pause' request Tom> would set the "do not emit the continue" flag. This meant that a Tom> subsequent request that should provoke a 'continue' event would Tom> instead suppress the event. Tom> I then tried writing a more obvious test case for this, involving an Tom> inferior call -- and discovered that gdb.events.cont does not fire for Tom> an inferior call. Tom> This patch installs a new event listener for gdb.events.inferior_call Tom> and arranges for this to emit continue and stop events when Tom> appropriate. It also fixes the original bug, by adding a check to Tom> exec_and_expect_stop. I'm going to check this in on trunk & the gdb-14 branch now. Tom