From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by sourceware.org (Postfix) with ESMTPS id 43D7E3858C42 for ; Wed, 15 Nov 2023 13:59:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 43D7E3858C42 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 43D7E3858C42 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d2f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700056742; cv=none; b=LWutOqjnMiObtZxu6vo2zjCUk+Pvstzka4nb61zXp94mJC4/WsJm7zEK0oynJKQtZXlAcct5sZjnYFWdUGo09FRhnhwLzmliL644bqnf1zur8wLgy/fEQpK2GmcD068AkyNnQzy3O+yjJ08K49m9vM5BJaAAwlF81G93iShH/eA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700056742; c=relaxed/simple; bh=mqlXYDRwTy/02rjSCe9HIbWLP5edOp53kdsGq+uiP9Q=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=NsaOgVMsLssylaxEH7ugsRtVILH/3y9gBiXM+HkkaD2U9F6RP7Eje5HcOuyprCqTCe6+Qfrxw+Fkk7R/z8LG2fLhQ7Z0lZW+m47uxCOOr5t7pHuuzUNNSnE3brEv8/lCZ0ctnH+IgOTpV50qaEMaeaE/H0aJKYwyT76NMDbrWb4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd2f.google.com with SMTP id ca18e2360f4ac-7b06841efdcso12201239f.2 for ; Wed, 15 Nov 2023 05:59:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1700056740; x=1700661540; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=oX6HEyihvTPFD6jWBadUxECLgjjX4yUaUyqEpkUNjEo=; b=JEHD4QS9MzhaMW0j+f3ImenDkPmdQwUl9TtuvlTp0/xaK/u4HhynQEdcvka9vl3D6U u0NR5q1G57S99JvTHbgi30t4c9b6j52M57q/uK6U6R+RTHTAkCVTpQMab2ujFPbEzu4n kaS25tDgYUes5w1zKKtiTQI2Xmw0l8yDfAcR5K0VIZ2UJ7krImea0FV3LqruOhHShUYl 9MTrl3DUqfQ+nAzpXND7xReqfh6WXX6WaXutuYkPV7eVrXSqnBDBIRTWYDdvYOEXZJTP +lhtsqFPVxN1XviddvZX4S+2hhExGIrykhX2rEUZPoVikRdJyDrbq0iHxLkZLlQbtU1k Hhfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700056740; x=1700661540; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oX6HEyihvTPFD6jWBadUxECLgjjX4yUaUyqEpkUNjEo=; b=PGiMm3UqtKl3sBgYtJniGqtUeXE1nk9OWDzL1F/nYCTNSG91MmQx70gAb8JRBWFRN0 rHZ2QuK6B45fbOThLJhe7pqWXt9GNOMUE0TFffUrAWaMK8eN+6Lit4t8Hhn3/JQvMKOr RRYgSfJGqVHkfWHbK+zN4JAJAJugs5XrJKt6cs0qgNjDZJEbKx30xYUDpP9HUvRrhM8y C6DDuB8LRnqaOE0j6exusQhZXx7kwUhxhJkNG+GRZ+F8F2MU+022DyhHrlRHbTeD8Xdi 13hLSCqfyWqCfJJbnvLhNZX4ezSh6RnUbyVQ1dqZpaHjMbMSMkLRCqFu1gXNuTGo/kqh ekxw== X-Gm-Message-State: AOJu0YyZOYBLamuzfPMMzUfP3bfefIX6U0oOLIs5SwYXfv7Z6jyggEb1 fvvXPPeXk4Cql2RNVb0w5WV9mQ== X-Google-Smtp-Source: AGHT+IFj4+S57AasLjtfYHjo+ZJoWlDtV/Uspt0BMSE2k/dUBklzYyea7MBYOWyxH9uVXdVkMsxmyQ== X-Received: by 2002:a5e:c80b:0:b0:7b0:1bbf:b050 with SMTP id y11-20020a5ec80b000000b007b01bbfb050mr12448456iol.1.1700056740442; Wed, 15 Nov 2023 05:59:00 -0800 (PST) Received: from murgatroyd (97-122-77-73.hlrn.qwest.net. [97.122.77.73]) by smtp.gmail.com with ESMTPSA id k4-20020a5e8904000000b007b01c6a57d5sm566215ioj.15.2023.11.15.05.58.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 05:59:00 -0800 (PST) From: Tom Tromey To: Tom de Vries Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 6/7] Handle the static link in FrameDecorator References: <20231101-dap-nested-function-v1-0-0b0c3b228ac7@adacore.com> <20231101-dap-nested-function-v1-6-0b0c3b228ac7@adacore.com> X-Attribution: Tom Date: Wed, 15 Nov 2023 06:58:59 -0700 In-Reply-To: (Tom de Vries's message of "Wed, 15 Nov 2023 13:31:55 +0100") Message-ID: <87o7fvnmn0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries writes: Tom> On 11/1/23 18:09, Tom Tromey wrote: >> +gdb_assert {[dict get $locals namedVariables] == 3} "two locals" Tom> This fails for me with gcc 7.5.0: Tom> ... Tom> FAIL: gdb.dap/ada-nested.exp: two locals Tom> ... I see the test is misnamed :( Tom> AFAICT, the mismatch is because we have named_variables == 4 instead of 3. Can you modify this line: set refs [lindex [dap_check_request_and_response "fetch variables" \ "variables" \ [format {o variablesReference [i %d] count [i 3]} \ $num]] \ 0] to use 'i 4' after 'count', then send the gdb.log? That will show what the extra variables are. Tom