From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 0B44B3858CDB for ; Wed, 8 Nov 2023 16:54:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0B44B3858CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0B44B3858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699462473; cv=none; b=n7I9dsxsoG7H03qkFGj6XY4MwHxHdJuaC+Tqi9aKSNDXggcNgJZCMfRciDRDGY/uUlEDOxmWzUHf4qnGtUikOYR+rKTFRW24LlyUAswPJ/oGijB97YAJZNtOdqe6k5zhPsfTOIEvKQBtoGZzLMXlG6g2tFk6/si8DDt2XZHNnpM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699462473; c=relaxed/simple; bh=ItuzqxHpU46tEwKATimewKRIPRt7ztcWZFiX8J31X90=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=KhD5ovE08MhmLbKrEurpsSOmNzH/pKNV1x03Dd/kDTCo22rqzJ5fJ/MrOvKXPkk1oEI8PXD0VVa+PK7C9mpTaYcdRRPQYM20UX/NURiZUNwCl7iXXDmJbwmvJn2xPhPRDp/j4ITzmSuSXmTba8FO29ZGO2MJfprs/GrTdZoEVYg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6004a.ext.cloudfilter.net ([10.0.30.197]) by cmsmtp with ESMTPS id 0l1PrA5lnKOkL0lozrnRXz; Wed, 08 Nov 2023 16:54:29 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 0loxr5ZCVwasU0loyrFshu; Wed, 08 Nov 2023 16:54:28 +0000 X-Authority-Analysis: v=2.4 cv=ZpP+lv3G c=1 sm=1 tr=0 ts=654bbd44 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=BNY50KLci1gA:10 a=Qbun_eYptAEA:10 a=VnNF1IyMAAAA:8 a=JZu7hwlnVv5BKHX8808A:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=uV8lWSmHHSMafiQn94YGa+7GdnlPdi5I1ziL6FIGSx4=; b=HaSSfOXfqUxNoxOchS5C4gols3 Je+rr6jviDM3UZwafbDQBMZk8Z2TOhv0ckYFh9ShUD8yOjxoWyR4IQxYCwoKouNsU1kF4OC8kOooY l0h0VCQU8ShWvs4k4OQgXOIWp; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:35776 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1r0lox-003heh-0O; Wed, 08 Nov 2023 09:54:27 -0700 From: Tom Tromey To: Carl Love Cc: Luis Machado , gdb-patches@sourceware.org, Tom Tromey , Guinevere Larsen , Ulrich Weigand Subject: Re: [PATCH ver 2] Fix the gdb.ada/inline-section-gc.exp test References: X-Attribution: Tom Date: Wed, 08 Nov 2023 09:54:45 -0700 In-Reply-To: (Carl Love's message of "Wed, 08 Nov 2023 08:22:43 -0800") Message-ID: <87o7g4rxre.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1r0lox-003heh-0O X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net (prentzel) [97.122.77.73]:35776 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJlD+qrJhLTvFRswc88aN0WmDPc2DzWNPDHKoFTawONHKwKZUUsNUsfbXW6t/6SlMN/io7zlZVZgN3iLwteJLpTD09QM0uGuQXNMYLlIgeEYYWhKOHCe bsoHH8UnaIPUZnbKYo1UDmQ4KQLcI5P+z0+Lg1aD9G57OQ3Ns1D2kZcsoiAKtpy158CSpuO05ihhA8T4en5qcllrszU+Iq1XQ/I= X-Spam-Status: No, score=-3018.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Carl" == Carl Love writes: Carl> GDB maintainers, Luis, Tom: Carl> Version 2, fixed the name of the test the patch fixes in the email. Carl> Mixed it up with another patch I am working on sorry about that. No worries. Carl> Here is the patch to fix test gdb.ada/inline-section-gc.exp on Carl> PowerPC as discussed on IRC. I think it looks good, but I have one nit. Carl> +set bp_location1 [gdb_get_line_number "BREAK" ${testdir}/callee.adb] Carl> +set bp_location2 [expr $bp_location1 - 1] It would be better to just stick some comment on the relevant line in caller.adb and then use gdb_get_line_number to fetch it. thanks, Tom