Re: [PATCH] [gdb/go] Handle v3 go_0 mangled prefix

[Tom Tromey <tom@tromey.com>]

>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:

Tom> A new v3 mangling scheme was used.  The mangling schemes define a separator
Tom> character and mangling character:
Tom> - for v2, dot is used both as separator character and mangling character, and
Tom> - for v3, dot is used as separator character and underscore as mangling
Tom>   character.

Tom> For more details, see [1] and [2].

Tom> In v3, "_0" demangles to ".". [ See gcc commit a01dda3c23b ("compiler, libgo:
Tom> change mangling scheme"), function Special_char_code::Special_char_code. ]

Tom> Handle the new go_0 prefix in unpack_mangled_go_symbol, which fixes the
Tom> test-case.

Looks good to me.

It took me a little while to realize that this:

Tom>    gdb::unique_xmalloc_ptr<char> result = make_unique_xstrdup (mangled_name);
Tom>    buf = result.get ();
...
Tom> +      /* Skip the '\0'.  */
Tom> +      buf++;

... is ok, but it is because the callers only use the unique_xmalloc_ptr
to manage the memory, they don't examine the pointer directly.

Approved-By: Tom Tromey <tom@tromey.com>

Tom