From: Tom Tromey <tom@tromey.com>
To: Alan Modra via Gdb-patches <gdb-patches@sourceware.org>
Cc: Alan Modra <amodra@gmail.com>
Subject: Re: gdb: bfd_get_symbol_leading_char vs. ""
Date: Wed, 23 Aug 2023 11:40:47 -0600 [thread overview]
Message-ID: <87o7ixveqo.fsf@tromey.com> (raw)
In-Reply-To: <ZOVjVgvIJH6HwmT/@squeak.grove.modra.org> (Alan Modra via Gdb-patches's message of "Wed, 23 Aug 2023 11:09:34 +0930")
>>>>> "Alan" == Alan Modra via Gdb-patches <gdb-patches@sourceware.org> writes:
Alan> Some places matching the first char of a string against
Alan> bfd_get_symbol_leading_char, which may be zero, didn't check for "".
Alan> This could lead to accesses past the end of the string and potential
Alan> buffer overruns.
Thank you.
Alan> Fix that, and also get rid of a stupid optimisation
Alan> in dbxread when looking for "__DYNAMIC" that also might access past
Alan> the end of a string.
Gross stuff even by old school standards.
Anyway, this is ok.
Tom
prev parent reply other threads:[~2023-08-23 17:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 1:39 Alan Modra
2023-08-23 17:40 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7ixveqo.fsf@tromey.com \
--to=tom@tromey.com \
--cc=amodra@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).