From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) by sourceware.org (Postfix) with ESMTPS id 3F3953858D1E for ; Wed, 2 Aug 2023 19:32:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3F3953858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x136.google.com with SMTP id e9e14a558f8ab-34617b29276so3635735ab.0 for ; Wed, 02 Aug 2023 12:32:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1691004765; x=1691609565; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=sc8F3OrpxLAWsbj4qxfrz1Ml9llZ3cZOGxSBPKDulpA=; b=iLuvtWIDcEwq6/ZtZ15FXP05OqUzaFeEQdWsGqDP8KRKirH8DUbX0qWFphtMEZ1eWw 4b3QaRYpDKqVGzVYT35b46WrCw1AlvUvqFrGuYbovb/a1kX9G2U+t2zS+/sz11IkpHhC 4xy6gVHIm4NAql2lYjH4kzo/80Gc8i/ZFnxpHn7ygnbNeDfFoM3nuzloj1/n/04Czngj a2qRpc8HDK/ij2Xzrk4M2H/0amTGTTUFNb0WK8/6gl5tlY551OEyb6XS4+7wx2HsncZE WL3OYuyApJgf7tLrO6JYRHttMVm0uOzy0ea+0w+sGA+wYgWkw4wMthKRq27HsERU9VR6 r66w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691004765; x=1691609565; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sc8F3OrpxLAWsbj4qxfrz1Ml9llZ3cZOGxSBPKDulpA=; b=Zf73+Pe+8tKb3F7IxtlVE74x5rT9cc7RDiMqIp5pNvBK16AehXB0ZB/8tWDyE5GxEv K+SO99AKpz4/L8jkmePXxdshv/QSGrefR5fJwfpzWhRiukjpTcU66Da57pn4KN2cj0h/ 8wjbctFXKkgzN9IyXdvHj5GH+6Pk3u4mEPNvFJ2pRC1OY2+6AoTlwBY1IfajXe42nZrh p0P2n7Ruun014DNE8rvcQ8i9fpzjPjjQFSQjr2jddpuCqEsPzPsgOx9NR2twVKI1u7v7 /RucuSUO61w4iU2cE7NX408BRcyR0vjAsi9OhmL4Z9Tp4jhR9CqdzbYUmj9B/AAmiSrR PDuQ== X-Gm-Message-State: ABy/qLbZcQhbILoFLNN2JzjMA8PQ1gosC9actydsbV/nWBRIPiYN8lK2 rhvSHTCLnJQN/MoeDvW7yGe6cA== X-Google-Smtp-Source: APBJJlEvtMrdwXv6EFKH14hgwf5mR9gmkyGEyENohq1O6x4eJG5vTMrLNnf0ww7+m4Lz2P9/o6WmLw== X-Received: by 2002:a05:6e02:1186:b0:349:2cd0:4364 with SMTP id y6-20020a056e02118600b003492cd04364mr7272842ili.14.1691004765414; Wed, 02 Aug 2023 12:32:45 -0700 (PDT) Received: from murgatroyd (75-166-148-59.hlrn.qwest.net. [75.166.148.59]) by smtp.gmail.com with ESMTPSA id e8-20020a92de48000000b003426356a35asm97292ilr.0.2023.08.02.12.32.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Aug 2023 12:32:44 -0700 (PDT) From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries Subject: Re: [PATCH v2 2/6] [gdb/symtab] Fix data race on bfd::{cacheable,format} References: <20230802095305.3668-1-tdevries@suse.de> <20230802095305.3668-3-tdevries@suse.de> X-Attribution: Tom Date: Wed, 02 Aug 2023 13:32:44 -0600 In-Reply-To: <20230802095305.3668-3-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Wed, 2 Aug 2023 11:53:01 +0200") Message-ID: <87o7jpdyub.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> With gdb build with -fsanitize=thread and test-case gdb.base/index-cache.exp I Tom> run into: Thanks again. Tom> -index_cache_store_context::index_cache_store_context (const index_cache &ic) Tom> +index_cache_store_context::index_cache_store_context (const index_cache &ic, Tom> + dwarf2_per_bfd *per_bfd) Ok, I see why explicit isn't needed :) This seems fine to me. Approved-By: Tom Tromey Tom