From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id 38E843858417 for ; Wed, 26 Jul 2023 13:45:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 38E843858417 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id D0EAC1004062D for ; Wed, 26 Jul 2023 13:45:23 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id OepPqpUEtaShIOepPqQdYg; Wed, 26 Jul 2023 13:45:23 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=SPmH6MjH c=1 sm=1 tr=0 ts=64c12373 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=ws7JD89P4LkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=odAETrUHpfJNT2_m9v8A:9 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=I8HPDoxECeGFL3UVyxphaVoAKCeyujjDUIMTQuV26DQ=; b=ZcuEw4HXGoGPgizWWqTOoMzxV3 mWILsD+UptCeNEpx5UQNNQAqh76QMAawpjOwOc4LhGk5w/Nx8fUegcTHOqhVUtaRwCbGte/Dw6DKf vzEJqjNclnSSzoaaYejH3bBSC; Received: from 75-166-135-140.hlrn.qwest.net ([75.166.135.140]:44466 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qOepP-004OlR-0l; Wed, 26 Jul 2023 07:45:23 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries Subject: Re: [PATCH] [gdb/build] Fix Wstringop-truncation in coff_getfilename References: <20230726084909.32090-1-tdevries@suse.de> X-Attribution: Tom Date: Wed, 26 Jul 2023 07:45:22 -0600 In-Reply-To: <20230726084909.32090-1-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Wed, 26 Jul 2023 10:49:09 +0200") Message-ID: <87o7jykcr1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.135.140 X-Source-L: No X-Exim-ID: 1qOepP-004OlR-0l X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-135-140.hlrn.qwest.net (murgatroyd) [75.166.135.140]:44466 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> When building gdb with -O2 -fsanitize-threads, I ran into Tom> a Werror=stringop-truncation. ... Tom> Fix this by using "sizeof (aux_entry->x_file.x_n.x_fname)" instead. Tom> Likewise in xcoffread.c. Tom> Tested on x86_64-linux. This seems fine to me. I wonder why this code is using a fixed-size buffer, but your fix is clearly an improvement anyway. Approved-By: Tom Tromey Tom