From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 5F82E3858D35 for ; Tue, 4 Jul 2023 11:20:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5F82E3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688469605; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KzJXeBHLAS14zV2Oja3k8BoA/8P8mtdJrppKjdxdXl0=; b=VzOPGbXv7cDj9lWqToeBEkuqPQvm8Ux0XEpBJJEK4Tchr2066071gWFqEy492v3c8xGaXz 8hQSytedtPO6TrMaTnRmlw7KmnQN9Oc1qCLutd+nT7evxYdR11tARx2yRCsffQJ5/trLUm v0t+4HNFBePdHvouOmsyyOSXleopzG4= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-385-XBsU3TMlOHiRaozaGXgqXQ-1; Tue, 04 Jul 2023 07:20:03 -0400 X-MC-Unique: XBsU3TMlOHiRaozaGXgqXQ-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-30e3ee8a42eso3186825f8f.1 for ; Tue, 04 Jul 2023 04:20:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688469602; x=1691061602; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KzJXeBHLAS14zV2Oja3k8BoA/8P8mtdJrppKjdxdXl0=; b=h96P+jvrcJlE64C4Q2SPQMTxlfhMby01zlY0AxgyOAHEhXDZ8bmJeGyevL8LygGisR c9QDNPvTgmOaa0e61Z2+/8Tx5hn9l1FmKfrQc/qpZ7R/+DswctTNJEeQzgKZKzcVZQi7 iEPLDni/kLNr7CBmKk2N7ispuNOgueCWulLqCLXg4WolfOSWLrQnG9IRLPzrJvA9dTZW U1psU2TPyEc9vkx3NKdq58pp2qMJGEcmq/epj3Qgxbr8JW99NgbXSu+/kJjTlU+E8lDN 9Q4i+QRcu1N+wx153P9uJ5RLsfnvLWlDCyoYL6GjYVGWknRGsooJVIp960vplhSBKWl2 qQMA== X-Gm-Message-State: ABy/qLYc8IFNqedqrtwjlD96m90xbQ8rZSIO3XhgBo8MLPjwAdQEUD0h dxUBA4dPHzvdXwct2bY8ic+JdYUy6BBmWb8FfRz2sDhUv9CzW5p2yZ4yZeSaDmVF6af7kSz+5Zz WboTPM55Gj7PGkbnL4TJhBxtmTRb9C/T5W5/eALvo8d6RxO4L7DI+KH51B35sisYKJpGyffMNc8 /BbQXeRg== X-Received: by 2002:a5d:494c:0:b0:314:3724:6fcb with SMTP id r12-20020a5d494c000000b0031437246fcbmr5382714wrs.50.1688469602485; Tue, 04 Jul 2023 04:20:02 -0700 (PDT) X-Google-Smtp-Source: APBJJlEQbQRJYMgNuPGTshVR+5B0TviYchCo4yiky13cW6DUtBg+hmxgpoMuBalmvOsXZvdIxjEftw== X-Received: by 2002:a5d:494c:0:b0:314:3724:6fcb with SMTP id r12-20020a5d494c000000b0031437246fcbmr5382703wrs.50.1688469602086; Tue, 04 Jul 2023 04:20:02 -0700 (PDT) Received: from localhost (2.72.115.87.dyn.plus.net. [87.115.72.2]) by smtp.gmail.com with ESMTPSA id z11-20020adfe54b000000b0031128382ed0sm9084530wrm.83.2023.07.04.04.20.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jul 2023 04:20:01 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Subject: Re: [PATCHv8 0/6] Infcalls from B/P conditions in multi-threaded inferiors In-Reply-To: References: Date: Tue, 04 Jul 2023 12:20:00 +0100 Message-ID: <87o7krly8v.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Andrew Burgess writes: I'm thinking about merging this series possibly later this week, or early next. I didn't get this on the list early enough for GDB 13, and I'd like to see this land for GDB 14. If there are any objections then, of course, I'll hold off merging this. Thanks, Andrew > In v8: > > - Rebased onto current upstream/master and retested. > > - Addressed feedback from Baris on patches 1, 2, 3, & 4. This was > mostly minor stuff, comment typos and some improvements to the > testsuite. There was one real (but minor) GDB change in patch 4. > > In v7: > > - Rebased onto current upstream/master, fixed use of > find_thread_ptid which is now a process_stratum_target method, > > - Retested, with no regressions seen. > > In v6: > > - Pushed the 5 initial patches. These were the smaller fixes, and, > I felt were pretty obvious fixes. I'm sure folk will raise > objections if they disagree. > > - Of the remaining patches, #1 to #5 really needs review before they > can be merged. Patch #6 is an obvious cleanup once the first five > have been merged. > > - I've rebased onto current HEAD of master, there's no significant > changes. > > - All other documentation changes have been reviewed and approved. > > In v5: > > - Rebased to current HEAD of master, minor merge conflict resolved. > No other code or documentation changes. > > - First patch, which was pure documentation, has now been merged. > > - All other documentation changes have been reviewed and approved. > > In v4: > > - I believe all the docs changes have been reviewed and approved by Eli, > > - Rebased onto current master, > > - Dropped patch #2 from the V3 series, > > - I have addressed all the issues Baris pointed out, including the > fixes for the patch #9 ('gdb: add timeouts for inferior function > calls'), which I forgot to do in V3. > > In v3: > > - Updates for review feedback, biggest changes in #10 and #11, but > minor changes to most patches. > > In V2: > > - Rebased onto something closer to HEAD of master, > > - Patches #1, #2, #12, and #13 are new in this series, > > - Patches #3 to #9, and #11 are unchanged since their V1 iteration, > > - Patches #10 has changed slightly in implementation since v1, and > the docs have been significantly updated. > > --- > > Andrew Burgess (6): > Revert "gdb: remove unnecessary parameter wait_ptid from > do_target_wait" > gdb: fix b/p conditions with infcalls in multi-threaded inferiors > gdb: add timeouts for inferior function calls > gdb/remote: avoid SIGINT after calling remote_target::stop > gdb: introduce unwind-on-timeout setting > gdb: rename unwindonsignal to unwind-on-signal > > gdb/NEWS | 38 +++ > gdb/breakpoint.c | 2 + > gdb/doc/gdb.texinfo | 105 ++++++- > gdb/gdbthread.h | 3 + > gdb/infcall.c | 296 +++++++++++++++++- > gdb/infrun.c | 70 ++++- > gdb/infrun.h | 3 +- > gdb/remote.c | 23 +- > gdb/testsuite/gdb.base/callfuncs.exp | 4 +- > gdb/testsuite/gdb.base/help.exp | 2 +- > gdb/testsuite/gdb.base/infcall-failure.exp | 4 +- > gdb/testsuite/gdb.base/infcall-timeout.c | 36 +++ > gdb/testsuite/gdb.base/infcall-timeout.exp | 97 ++++++ > gdb/testsuite/gdb.base/unwindonsignal.exp | 36 ++- > gdb/testsuite/gdb.compile/compile-cplus.exp | 2 +- > gdb/testsuite/gdb.compile/compile.exp | 2 +- > gdb/testsuite/gdb.cp/gdb2495.exp | 16 +- > gdb/testsuite/gdb.fortran/function-calls.exp | 2 +- > gdb/testsuite/gdb.mi/mi-syn-frame.exp | 2 +- > .../infcall-from-bp-cond-other-thread-event.c | 135 ++++++++ > ...nfcall-from-bp-cond-other-thread-event.exp | 174 ++++++++++ > .../gdb.threads/infcall-from-bp-cond-simple.c | 89 ++++++ > .../infcall-from-bp-cond-simple.exp | 235 ++++++++++++++ > .../gdb.threads/infcall-from-bp-cond-single.c | 139 ++++++++ > .../infcall-from-bp-cond-single.exp | 117 +++++++ > .../infcall-from-bp-cond-timeout.c | 169 ++++++++++ > .../infcall-from-bp-cond-timeout.exp | 173 ++++++++++ > .../gdb.threads/thread-unwindonsignal.exp | 8 +- > 28 files changed, 1902 insertions(+), 80 deletions(-) > create mode 100644 gdb/testsuite/gdb.base/infcall-timeout.c > create mode 100644 gdb/testsuite/gdb.base/infcall-timeout.exp > create mode 100644 gdb/testsuite/gdb.threads/infcall-from-bp-cond-other-thread-event.c > create mode 100644 gdb/testsuite/gdb.threads/infcall-from-bp-cond-other-thread-event.exp > create mode 100644 gdb/testsuite/gdb.threads/infcall-from-bp-cond-simple.c > create mode 100644 gdb/testsuite/gdb.threads/infcall-from-bp-cond-simple.exp > create mode 100644 gdb/testsuite/gdb.threads/infcall-from-bp-cond-single.c > create mode 100644 gdb/testsuite/gdb.threads/infcall-from-bp-cond-single.exp > create mode 100644 gdb/testsuite/gdb.threads/infcall-from-bp-cond-timeout.c > create mode 100644 gdb/testsuite/gdb.threads/infcall-from-bp-cond-timeout.exp > > > base-commit: baab375361c365afee2577c94cbbd3fdd443d6da > -- > 2.25.4