From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by sourceware.org (Postfix) with ESMTPS id AAEE83858428 for ; Thu, 22 Jun 2023 22:52:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AAEE83858428 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-9881b9d8cbdso211261966b.1 for ; Thu, 22 Jun 2023 15:52:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687474346; x=1690066346; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=Q8vKlcEn8+kQngPAKqKCtWsLNHBFA5FG5NVZIluHTtM=; b=oQ+OYz6nJeZdG59J81ja/o58lz4Y+esSlvTVtVDExLsFEikWxnoJ3xl8gm6W1zlnqh PX71T3Pj5f+jxOywkF1Metm5FOC8gUKHeSr88Hf0Jd3DUSnT2/rl0zfHV+MW0pGhAakJ H+aPs8Je+BmVQ0K8N5sLI3Gkf2amtH/ZLrboDLYBDerwQUE684hCa29sc2F0Aj1AA0MJ XWJvu07to2cDEiArvi2A5rNBQFqSsuQSPoJ7Lidlvnto0FYr3Fj7LuGOjm0dNZrN2qLN nNeW33Wp/Q9UKzJUB4SgHTTwFOTyzWLKmmLg0BTDAUMfPRwFBIbqevFzmUGVZk/rVvtG trcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687474346; x=1690066346; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q8vKlcEn8+kQngPAKqKCtWsLNHBFA5FG5NVZIluHTtM=; b=WZ+9u4gni2bZ8rFhZoInYJBTNiJkXX3fFNyVex//3W+JNPGwJ11aTkeIwHDMjQvgi0 Ja+0tXvA4XwFL1/fVt7Vev+4S7I7QRcjXnPRb0VEysG+IYRp05fRiVxP6YH73y6gqWJA KGAjL3EGrYWnEzUFnPdBX5Hngn4JOtqFP+GdSxItqOanDAii1zWYkGCmE4cWLrWlHlX1 2vaYrW6QHwRMEO8HCqiUifhVtYJE2gHoJEc8qNy3ONEG0XqRUOlWHCv59iyhplxgpx02 FaA1H8pK+BhXkky86KhMnJPiygTjyGmA6aXyC5T6Q7NDv1oIbdWF5pYZNzVJkCidsxyM oFIg== X-Gm-Message-State: AC+VfDzCD2g4iQi5KeUA7/EPni6jBPq9EnNw1RPkHc+Ge7D9qgWlcyp1 o77MCYbOh1WcoC0H7cgBJwSG/IbuZaqPpJQaAA2XnA== X-Google-Smtp-Source: ACHHUZ5JpTsEMfFWlnH8CoWprxutoZbEhP+GCb56+K8PEXQIP8a7qIIVqTsHyd2Sa0D52jnG4FHTbA== X-Received: by 2002:a17:907:ea1:b0:98b:dc6c:b2f9 with SMTP id ho33-20020a1709070ea100b0098bdc6cb2f9mr6258378ejc.6.1687474346257; Thu, 22 Jun 2023 15:52:26 -0700 (PDT) Received: from localhost ([2a02:908:f60:bc60:3857:f6ca:2fe4:914b]) by smtp.gmail.com with ESMTPSA id u13-20020a170906b10d00b00988955f7b5esm5220671ejy.157.2023.06.22.15.52.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 15:52:25 -0700 (PDT) References: <20230605232844.80533-1-thiago.bauermann@linaro.org> <4cce28ea-a883-7391-daa8-130f9bc553c1@redhat.com> User-agent: mu4e 1.10.3; emacs 28.2 From: Thiago Jung Bauermann To: gdb-patches@sourceware.org Cc: Andrew Burgess , Tom de Vries , Bruno Larsen Subject: Re: [PATCH v3] gdb/testsuite: Avoid infinite loop in gdb.reverse/step-reverse.exp In-reply-to: <4cce28ea-a883-7391-daa8-130f9bc553c1@redhat.com> Date: Fri, 23 Jun 2023 00:52:24 +0200 Message-ID: <87o7l7glef.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Bruno Larsen writes: > On 06/06/2023 01:28, Thiago Jung Bauermann wrote: >> This testcase sometimes gets stuck in a loop for hours when running in our >> CI. The problem is that due to an issue unrelated to reverse debugging the >> inferior exits early, and because of the overly generic ".*" pattern the >> testcase keeps sending the "next" command without noticing that the >> inferior is gone. >> >> gdb_test_multiple has a pattern to detect that "The program is not being >> run.", but since it is placed after the patterns from the caller it won't >> be triggered. It also has a timeout pattern but because it is triggered >> between successful matches, each time the test matches the '-re -wrap ".*"' >> this counts as a successful match and the timeout is reset. >> >> Since the test binary is compiled with debug information, fix by changing >> one of the generic patterns to match entering the main function and the >> other one to match the source code line number that is shown by GDB right >> after the "step" command. >> >> Also, as a precaution add a maximum number of times the "next" command will >> be sent. >> >> Co-Authored-By: Tom de Vries >> --- > > Thanks for fixing all the nits, looks good to me now. Reviewed-By: Bruno Larsen > > > (Just making sure you know, the rb tag is not enough to push, you need an approval) Ping. -- Thiago