From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C08053858438 for ; Fri, 28 Apr 2023 16:43:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C08053858438 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682700224; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MLclGdvPdTn5mqH3/tLFxIlDwUKelbxJ2kEO32TLD3E=; b=X4ZEW41yNK1YSFhF/BVOdj/QeaI6Tj+NevyWTLC1byLO0tArNJfhazGMjiGW2Pl3X/1pxS Wr5wuplkXIO2TKQrIw61pvsL0LLr2Q2jCtBo0Sp3iw/+cJgWPVYDDZn90q2EJYddmd4/4P tVRSNrnr3NPJ66Hi5AfFiLLOLdLXSio= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-17-8BIcVeQFPTijGwBQ4NdNIA-1; Fri, 28 Apr 2023 12:43:43 -0400 X-MC-Unique: 8BIcVeQFPTijGwBQ4NdNIA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3f32b3835e9so2018925e9.1 for ; Fri, 28 Apr 2023 09:43:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682700222; x=1685292222; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MLclGdvPdTn5mqH3/tLFxIlDwUKelbxJ2kEO32TLD3E=; b=RLDweqYIPKuXy6Z01Fp+obu5yXz5RxQNSkn1McxZoibsG2cZL5yBQzMKYGePv3/NCw 8rVrnrYN1BcJVdjf1LByx7xujPt7x0lAXJUkLArFUqfWF0NQRIC0kXQdZV7qad1xJTyj zVEWQJ/9rd2hq4dOe79vqoDhxruHDdoa5/V4wfPHpChQI5QKgrNeiiaPoVOvbMuGRcKJ J0seL/b2e9eA/iJgOvU2U+VAwpG95oKL0FH1bhvWyZCRu+GL9oZjIBIKBq1RrK2fwL3v sZ8ui/973yOMELfd/eRrz/4fBr7pXd13l2ZeUOBPpHm59LIxFaXjlq/FRc+JkP2VSlcD bHnQ== X-Gm-Message-State: AC+VfDxo0HnYIOA4J6/sM4gE985Oq+7DXZRIdJU0y/0yfzgDfEKVmtv4 VS3NPACEtTHLWMO6FMQLXEisdHjykyQZUKjRVdbUAd2lCEQTAoBlsh97ojTsjUBB21Qk0iM4AKz tre9mpGET90kMPZNfShoOln/TtzfTdw== X-Received: by 2002:a05:600c:298:b0:3ee:1acd:b039 with SMTP id 24-20020a05600c029800b003ee1acdb039mr4821351wmk.34.1682700222049; Fri, 28 Apr 2023 09:43:42 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ58I6xgS7sWOAl0wFwtMErkA1kec++MWaRJh0SV/0TpcoVrL6eJVUlRsSTh+zu5R6x6fqHcaA== X-Received: by 2002:a05:600c:298:b0:3ee:1acd:b039 with SMTP id 24-20020a05600c029800b003ee1acdb039mr4821342wmk.34.1682700221809; Fri, 28 Apr 2023 09:43:41 -0700 (PDT) Received: from localhost (92.40.218.120.threembb.co.uk. [92.40.218.120]) by smtp.gmail.com with ESMTPSA id v16-20020a05600c471000b003ede3f5c81fsm28633423wmo.41.2023.04.28.09.43.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Apr 2023 09:43:41 -0700 (PDT) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 0/5] Fixes for per-inferior settings and $_gdb_setting_str() In-Reply-To: <636ce26d-19e9-124e-5323-8362a9928bcd@simark.ca> References: <636ce26d-19e9-124e-5323-8362a9928bcd@simark.ca> Date: Fri, 28 Apr 2023 17:43:39 +0100 Message-ID: <87o7n89cuc.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Simon Marchi writes: > On 4/4/23 08:45, Andrew Burgess via Gdb-patches wrote: >> While working on another patch I spotted that >> $_gdb_setting_str("args") wasn't working correctly. Turns out args, >> cwd, and inferior-tty all have the same problems. This series >> resolves these issues. > > That rang a bell, it's because I have fixed some of these downstream in > ROCgdb, and haven't sent it upstream yet. The downstream commit is > here: > > https://github.com/ROCm-Developer-Tools/ROCgdb/commit/54d0a79614071fd62df5e2dfe793ff26cc7e31e6 In case I miss this patch when you upstream it, the removal of show_remote_exec_file should be dropped. The generic code doesn't handle internationalisation, and though show_remote_exec_file itself also doesn't do internationalisation, the correct (IMHO) thing would be to fix show_remote_exec_file, not remove it. > > I'll take a look at your patches, I presume that they will do mostly the > same thing. And if my patch does more (according to the commit message, > it fixes "remote exec-file" and "tdesc filename"), I can send what > remains after. I'll take a look at the testing in your patch and see if I can extend the tests in my patch a little. Thanks, Andrew